Add Lineage and Motorola settings database To SetEdit.#42
Open
Tharow wants to merge 5 commits intoMuntashirAkon:masterfrom
Open
Add Lineage and Motorola settings database To SetEdit.#42Tharow wants to merge 5 commits intoMuntashirAkon:masterfrom
Tharow wants to merge 5 commits intoMuntashirAkon:masterfrom
Conversation
TODO: hide Unavailable Settings Databases Manifest Lists Used queries
MuntashirAkon
requested changes
Oct 16, 2024
Owner
MuntashirAkon
left a comment
MuntashirAkon
left a comment
There was a problem hiding this comment.
Looks mostly okay, except the 4 issues that needs to be addressed. Thanks.
app/src/main/java/io/github/muntashirakon/setedit/EditorActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/io/github/muntashirakon/setedit/utils/SettingsUtils.java
Show resolved
Hide resolved
app/src/main/java/io/github/muntashirakon/setedit/utils/SettingsUtils.java
Show resolved
Hide resolved
Found and implemented LOS settings command in SettingsUtils.java Further edits made to inform user of root requirements for motorola table. Signed-off-by: Theray Tharow <tharowt@tharow.net>
Author
|
After personal testing, prompt on attempted edit of Motorola table without root, was added |
So canEdit is false for the motorola table unless the the user somehow has access. in the similar way to the AndroidPropertiesRecyclerAdapter.java Signed-off-by: Theray Tharow <tharowt@tharow.net>
Author
|
Prompt removed as it always causes a crashed after a permission fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open to reformating code to match existing code as desired.
This could also be completed with by adding a settingsLocation along with settingstype in the SettingsRecyclerAdapter.
This alternate solution could be made if desired.
#41