change constructor of OrnsteinUhlenbeckDiffusion#31
change constructor of OrnsteinUhlenbeckDiffusion#31bicycle1885 wants to merge 2 commits intomainfrom
Conversation
|
I also usually work with a mean,reversion,eq_std parameterization, so I'm happy with this direction. The optional arguments should allow the equilibrium std to be input directly. Maybe we call that |
|
I'm wondering how often we will change the parameter σ in practice. I think most users won't tune that parameter; if they do, they must know what they do. Introducing a new parameter like |
|
Playing with toy cases, the equilibrium std can make a practical difference for how easily the model learns. It is one of the things I tune. And anyone that knows what they're doing will understand the meaning of "eq", and can set the parameters directly if they like! |
I'd like to propose changing the parametrization of the constructor of
OrnsteinUhlenbeckDiffusion. The rationale behind this is that we typically want to tune the speed of convergence by changing the reversion parameter while keeping the distribution at equilibrium unchanged. Also, I think we won't tune the mean parameter in most cases because it is not very important in diffusion models. I also added a short docstring to the constructor.