Skip to content

Fix double-launch flashing a port-in-use error #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MyNamesEMurray merged 2 commits into from
Jul 18, 2026
Merged

Fix double-launch flashing a port-in-use error #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f04e900
Fix double-launch flashing a port-in-use error
claude Jul 18, 2026
c3d9ab0
Merge remote-tracking branch 'origin/main' into claude/single-instanc…
claude Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions electron/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,21 @@ const SMOKE = Boolean(process.env.HG_SMOKE); // CI/smoke mode: no UI, auto-quit
// Required for Windows notifications/toasts to render at all.
app.setAppUserModelId('com.hypeghost.app');

// Only one Hype Ghost at a time — a second launch just shows the existing window.
// Only one Hype Ghost at a time — a second launch hands focus to the first
// instance instead of starting a rival. NOTE: app.quit() is asynchronous, so
// losing the lock must also gate the whenReady() block below — otherwise the
// doomed second instance still boots a server into the occupied port and
// flashes a "port already in use" error before its quit lands.
const gotLock = app.requestSingleInstanceLock();
if (!gotLock) {
app.quit();
} else {
app.on('second-instance', () => showWindow());
// Fired in the FIRST instance when a second launch is attempted: restore
// from minimized, recreate from tray mode, and bring to the foreground.
app.on('second-instance', () => {
if (win && !win.isDestroyed() && win.isMinimized()) win.restore();
showWindow();
});
}

// Installed app: data lives in %APPDATA%/Hype Ghost (writable, survives
Expand Down Expand Up @@ -163,7 +172,9 @@ function createTray() {
tray.on('double-click', () => showWindow());
}

app.whenReady().then(() => {
// Gated on the lock: without this, the losing instance's whenReady still
// fires before its queued app.quit() and boots a second server (see above).
if (gotLock) app.whenReady().then(() => {
ensureConfig();
try {
server = startServer({
Expand Down