Added dimension types to height/width attribute - #538
Open
CarsonDDD wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the width/height are limited to pixels. While this is good, often time when writing UI code (similar to MML) it is helpful to use percentages of the parent container.
In this I have made it so the dimension type of height/width is explicitly stated and controlled.
The types now available are:
"auto": explicit the old null/default value of wrapping."fill"-
"ZZ%"percentage of parent space"ZZpx"If none is given, it will default to using pixels. This means it works on existing layouts.
Types are case insensitive.