Hotkey recording in Settings Window#296
Conversation
|
I think the code is ok, just that maybe it should also be applicable to the shell commands hotkeys |
|
added and merge conflicts fixed |
unsecretised
left a comment
There was a problem hiding this comment.
I've reviewed the code.. I'll try out the implementation and then I'll approve
There was a problem hiding this comment.
Maybe we should consider using a custom widget so that we can simply add this to the commands tab as well.
unsecretised
left a comment
There was a problem hiding this comment.
Seems to work as intended, but the only issue is, i've noticed that when i change something in the settings, the hotkeys stop working. Can that be fixed?
|
Sorry for the late followup, in the middle of a cross country move. Not sure exactly what you mean. Testing on my machine clicking into keybinding, type new keys, esc, pressing the new keybinding successfully executes the action. Alternatively, changing a setting, then pressing a keybind still works fine. Let me know what issues you're seeing on your end is! |
|
Huh ok.. then I'll merge it.. I'll take a look into it later.. |
This PR references a discord conversation about adding hotkey recording support in the Settings UI for both toggle the view and opening the clipboard history. This PR also cleans up a clippy error from the settings UI change that had dead code for reset fields no longer in use.
New Behavior
Screen.Recording.2026-07-11.at.15.30.43.mov