Skip to content

Improve device picker cached refresh#8

Merged
N0ahTM merged 1 commit into
developfrom
feature/cached-device-picker-refresh
Jun 19, 2026
Merged

Improve device picker cached refresh#8
N0ahTM merged 1 commit into
developfrom
feature/cached-device-picker-refresh

Conversation

@N0ahTM

@N0ahTM N0ahTM commented Jun 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Show cached device picker entries immediately before kicking off a fresh device enumeration.
  • Add a small header refresh indicator for background refreshes while keeping the existing blocking spinner for first load.
  • Cache plain device IDs/names in the picker view model instead of retaining DeviceInformation objects for later UI rebuilds.

Validation

  • Rebased onto current origin/develop after command-line support landed.
  • msbuild AudioPlaybackConnector2\\AudioPlaybackConnector2.vcxproj /p:Configuration=Debug /p:Platform=x64 /p:PreferredToolArchitecture=x64
  • clang-format --dry-run --Werror AudioPlaybackConnector2/include/ui/DevicePickerViewModel.hpp AudioPlaybackConnector2/src/ui/DevicePickerViewModel.cpp AudioPlaybackConnector2/ui/DevicePickerView/DevicePickerView.xaml.cpp AudioPlaybackConnector2/ui/DevicePickerView/DevicePickerView.xaml.h
  • cppcheck --enable=warning,performance,portability --std=c++20 --platform=win64 AudioPlaybackConnector2/src/
  • Runtime smoke test from the packaged AppX debug output: app initialized, tray picker opened/closed, device selection triggered connect, and OpenAsync returned Success.

Notes

The GitHub build workflow currently runs only for PRs targeting main, so PRs targeting develop report no GitHub checks. Local build/static checks were run after rebasing onto develop.

@N0ahTM
N0ahTM force-pushed the feature/cached-device-picker-refresh branch from 8036123 to a899f53 Compare June 19, 2026 15:36
@N0ahTM
N0ahTM changed the base branch from main to develop June 19, 2026 15:36
@N0ahTM
N0ahTM marked this pull request as ready for review June 19, 2026 15:37
@N0ahTM
N0ahTM merged commit 2be5446 into develop Jun 19, 2026
@N0ahTM
N0ahTM deleted the feature/cached-device-picker-refresh branch June 19, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant