Add default Derivation Group associations for Plans at the Model level #1934
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,328 @@ | ||
| <svelte:options immutable={true} /> | ||
|
|
||
| <script lang="ts"> | ||
| import { base } from '$app/paths'; | ||
| import type { CellEditingStoppedEvent, ICellRendererParams, ValueGetterParams } from 'ag-grid-community'; | ||
| import ExternalSourceIcon from '../../assets/external-source-box.svg?component'; | ||
| import { derivationGroups, externalSources } from '../../stores/external-source'; | ||
| import { plugins } from '../../stores/plugins'; | ||
| import type { User } from '../../types/app'; | ||
| import type { DataGridColumnDef } from '../../types/data-grid'; | ||
| import type { DerivationGroup, ExternalSourceSlim } from '../../types/external-source'; | ||
| import { getDerivationGroupRowId } from '../../utilities/externalEvents'; | ||
| import { featurePermissions } from '../../utilities/permissions'; | ||
| import { formatDate } from '../../utilities/time'; | ||
| import Collapse from '../Collapse.svelte'; | ||
| import Input from '../form/Input.svelte'; | ||
| import CssGrid from '../ui/CssGrid.svelte'; | ||
| import CssGridGutter from '../ui/CssGridGutter.svelte'; | ||
| import DataGrid from '../ui/DataGrid/DataGrid.svelte'; | ||
| import DataGridActions from '../ui/DataGrid/DataGridActions.svelte'; | ||
| import Panel from '../ui/Panel.svelte'; | ||
| import SectionTitle from '../ui/SectionTitle.svelte'; | ||
|
|
||
| export let user: User | null; | ||
| export let selectedDerivationGroups: string[]; | ||
|
Contributor
There was a problem hiding this comment. I can't seem to select a derivation group by clicking on a row in the DG table
Contributor
There was a problem hiding this comment. Ah - i have to click on the expand button.. any reason not to just use left click to trigger the detail view like we do in the other tables in the other tabs?
Contributor
Author
There was a problem hiding this comment. No reason in particular. This was modeled after how it works in the plan view (see
Contributor
There was a problem hiding this comment. Makes sense - I'd vote to align it with the other tabs in there just for consistency |
||
|
|
||
| type CellRendererParams = { | ||
| viewDerivationGroup: (derivationGroup: DerivationGroup) => void; | ||
| }; | ||
| type DerivationGroupCellRendererParams = ICellRendererParams<DerivationGroup> & CellRendererParams; | ||
|
|
||
| const derivationGroupBaseColumnDefs: DataGridColumnDef<DerivationGroup>[] = [ | ||
| { | ||
| field: 'name', | ||
| filter: 'string', | ||
| headerName: 'Derivation Group', | ||
| resizable: true, | ||
| sortable: true, | ||
| suppressAutoSize: false, | ||
| suppressSizeToFit: false, | ||
| }, | ||
| { | ||
| field: 'source_type_name', | ||
| filter: 'string', | ||
| headerName: 'Source type', | ||
| resizable: true, | ||
| sortable: true, | ||
| suppressAutoSize: false, | ||
| suppressSizeToFit: false, | ||
| }, | ||
| { | ||
| field: 'owner', | ||
| filter: 'string', | ||
| headerName: 'Owner', | ||
| resizable: true, | ||
| sortable: true, | ||
| }, | ||
| { | ||
| field: 'derived_event_total', | ||
| filter: 'number', | ||
| headerName: 'Derived Events in Derivation Group', | ||
| sortable: true, | ||
| suppressAutoSize: true, | ||
| suppressSizeToFit: true, | ||
| valueFormatter: params => { | ||
| return params?.value.length; | ||
| }, | ||
| width: 250, | ||
| }, | ||
| ]; | ||
|
|
||
| let dataGrid: DataGrid<DerivationGroup>; | ||
| let derivationGroupColumnDefs: DataGridColumnDef<DerivationGroup>[] = derivationGroupBaseColumnDefs; | ||
|
|
||
| let filterText: string = ''; | ||
| let filteredDerivationGroups: DerivationGroup[] = []; | ||
|
|
||
| let selectedDerivationGroup: DerivationGroup | undefined = undefined; | ||
| let selectedDerivationGroupSources: ExternalSourceSlim[] = []; | ||
|
|
||
| let hasUpdateDerivationGroupLinkPermission: boolean = false; | ||
|
|
||
| $: hasUpdateDerivationGroupLinkPermission = | ||
| featurePermissions.derivationGroupModelLink.canCreate(user) && | ||
| featurePermissions.derivationGroupModelLink.canDelete(user); | ||
|
|
||
| $: if (selectedDerivationGroups && dataGrid) { | ||
| dataGrid.refreshCells({ columns: ['selected'] }); | ||
| } | ||
|
|
||
| $: selectedDerivationGroupSources = $externalSources.filter( | ||
| source => selectedDerivationGroup?.name === source.derivation_group_name, | ||
| ); | ||
|
|
||
| $: filteredDerivationGroups = $derivationGroups.filter(derivationGroup => { | ||
| const filterTextLowerCase = filterText.toLowerCase(); | ||
| const includesName = derivationGroup.name.toLocaleLowerCase().includes(filterTextLowerCase); | ||
| return includesName; | ||
| }); | ||
|
|
||
| $: derivationGroupColumnDefs = [ | ||
| ...derivationGroupBaseColumnDefs, | ||
| { | ||
| cellDataType: 'boolean', | ||
| colId: 'selected', | ||
| editable: hasUpdateDerivationGroupLinkPermission, | ||
| headerName: 'Included in Model', | ||
| resizable: false, | ||
| suppressAutoSize: true, | ||
| suppressSizeToFit: true, | ||
| valueGetter: (params: ValueGetterParams<DerivationGroup>) => { | ||
| const { data } = params; | ||
| if (data) { | ||
| return selectedDerivationGroups.includes(data.name); | ||
| } | ||
| return false; | ||
| }, | ||
| width: 115, | ||
| }, | ||
| { | ||
| cellClass: 'action-cell-container', | ||
| cellRenderer: (params: DerivationGroupCellRendererParams) => { | ||
| const actionsDiv = document.createElement('div'); | ||
| actionsDiv.className = 'actions-cell'; | ||
| new DataGridActions({ | ||
| props: { | ||
| rowData: params.data, | ||
| viewCallback: params.viewDerivationGroup, | ||
| viewTooltip: { | ||
| content: 'View Derivation Group', | ||
| placement: 'bottom', | ||
| }, | ||
| }, | ||
| target: actionsDiv, | ||
| }); | ||
|
|
||
| return actionsDiv; | ||
| }, | ||
| cellRendererParams: { | ||
| viewDerivationGroup, | ||
| } as CellRendererParams, | ||
| headerName: '', | ||
| resizable: false, | ||
| sortable: false, | ||
| suppressAutoSize: true, | ||
| suppressSizeToFit: true, | ||
| width: 40, | ||
| }, | ||
| ]; | ||
|
|
||
| $: if (selectedDerivationGroups) { | ||
| dataGrid?.redrawRows(); | ||
| } | ||
|
|
||
| function viewDerivationGroup(viewedDerivationGroup: DerivationGroup) { | ||
| const derivationGroup = $derivationGroups.find( | ||
| derivationGroup => derivationGroup.name === viewedDerivationGroup.name, | ||
| ); | ||
| if (derivationGroup === selectedDerivationGroup) { | ||
| selectedDerivationGroup = undefined; | ||
| } else { | ||
| selectedDerivationGroup = derivationGroup; | ||
| } | ||
| } | ||
|
|
||
| function onToggleDerivationGroup(event: CustomEvent<CellEditingStoppedEvent<DerivationGroup, boolean>>) { | ||
| const { | ||
| detail: { data, newValue }, | ||
| } = event; | ||
|
|
||
| if (data && newValue !== null && newValue !== undefined) { | ||
| if (newValue && !selectedDerivationGroups.includes(data.name)) { | ||
| selectedDerivationGroups = [...selectedDerivationGroups, data.name]; | ||
| } else if (!newValue && selectedDerivationGroups.includes(data.name)) { | ||
| selectedDerivationGroups = selectedDerivationGroups.filter(dg => dg !== data.name); | ||
| } | ||
| } | ||
| } | ||
| </script> | ||
|
|
||
| <div class="metadata-container"> | ||
| <div class="metadata-filter-container"> | ||
| <CssGrid columns="1fr 3px 1fr" minHeight="100%"> | ||
| <div class="derivation-groups-modal-container"> | ||
| <div class="derivation-groups-modal-filter-container"> | ||
| <Input layout="inline"> | ||
| <input bind:value={filterText} class="st-input" placeholder="Filter derivation groups" /> | ||
| </Input> | ||
| <button | ||
| class="st-button secondary ellipsis new-external-source-button" | ||
| name="new-external-source" | ||
| on:click={() => window.open(`${base}/external-sources`)} | ||
| > | ||
| Upload | ||
| </button> | ||
| </div> | ||
| <hr /> | ||
| <div class="derivation-groups-modal-table-container"> | ||
| <DataGrid | ||
| bind:this={dataGrid} | ||
| columnDefs={derivationGroupColumnDefs} | ||
| noRowsOverlayText="No Derivation Groups Found" | ||
| rowData={filteredDerivationGroups} | ||
| getRowId={getDerivationGroupRowId} | ||
| on:cellEditingStopped={onToggleDerivationGroup} | ||
| /> | ||
| </div> | ||
| </div> | ||
| {#if selectedDerivationGroup !== undefined} | ||
| <CssGridGutter track={1} type="column" /> | ||
| <Panel borderRight padBody={true} overflowYBody="scroll"> | ||
| <svelte:fragment slot="header"> | ||
| <SectionTitle overflow="hidden"> | ||
| <ExternalSourceIcon slot="icon" />Sources in '{selectedDerivationGroup.name}' | ||
| </SectionTitle> | ||
| </svelte:fragment> | ||
| <svelte:fragment slot="body"> | ||
| {#if selectedDerivationGroupSources.length > 0} | ||
| {#each selectedDerivationGroupSources as source} | ||
| <!-- Collapsible details --> | ||
|
AaronPlave marked this conversation as resolved.
|
||
| <Collapse title={source.key} tooltipContent={source.key} defaultExpanded={false}> | ||
| <svelte:fragment slot="right"> | ||
| <p class="st-typography-body derived-event-count"> | ||
| {selectedDerivationGroup.sources.get(source.key)?.event_counts} events | ||
| </p> | ||
| </svelte:fragment> | ||
| <div class="st-typography-body"> | ||
| <div class="st-typography-bold">Key:</div> | ||
| {source.key} | ||
| </div> | ||
|
|
||
| <div class="st-typography-body"> | ||
| <div class="st-typography-bold">Source Type:</div> | ||
| {source.source_type_name} | ||
| </div> | ||
|
|
||
| <div class="st-typography-body"> | ||
| <div class="st-typography-bold">Start Time:</div> | ||
| {formatDate(new Date(source.start_time), $plugins.time.primary.format)} | ||
| </div> | ||
|
|
||
| <div class="st-typography-body"> | ||
| <div class="st-typography-bold">End Time:</div> | ||
| {formatDate(new Date(source.end_time), $plugins.time.primary.format)} | ||
| </div> | ||
|
|
||
| <div class="st-typography-body"> | ||
| <div class="st-typography-bold">Valid At:</div> | ||
| {formatDate(new Date(source.valid_at), $plugins.time.primary.format)} | ||
| </div> | ||
|
|
||
| <div class="st-typography-body"> | ||
| <div class="st-typography-bold">Created At:</div> | ||
| {formatDate(new Date(source.created_at), $plugins.time.primary.format)} | ||
| </div> | ||
| </Collapse> | ||
| {/each} | ||
| {:else} | ||
| <p class="st-typography-body">No sources in this group.</p> | ||
| {/if} | ||
| </svelte:fragment> | ||
| </Panel> | ||
| {/if} | ||
| </CssGrid> | ||
| </div> | ||
| </div> | ||
|
|
||
| <style> | ||
| .derivation-groups-modal-container { | ||
| display: grid; | ||
| grid-template-rows: min-content min-content auto; | ||
| height: 100%; | ||
| height: 100%; | ||
| row-gap: 0.5rem; | ||
| } | ||
|
|
||
| .derivation-groups-modal-container hr { | ||
| border: none; | ||
| border-top: 1px solid #e0e0e0; | ||
| margin: 0 1rem; | ||
| width: auto; | ||
| } | ||
|
|
||
| .derivation-groups-modal-filter-container { | ||
| align-items: center; | ||
| column-gap: 0.25rem; | ||
| display: flex; | ||
| grid-template-columns: min-content auto min-content; | ||
| margin: 0.5rem 1rem 0; | ||
| } | ||
|
|
||
| .derivation-groups-modal-table-container { | ||
| height: 400px; | ||
| padding: 0 1rem 0.5rem; | ||
| width: 900px; | ||
| } | ||
|
|
||
| .derived-event-count { | ||
| color: var(--st-gray-60); | ||
| } | ||
|
|
||
| .new-external-source-button { | ||
| align-items: center; | ||
| display: flex; | ||
| width: 100px; | ||
| } | ||
|
|
||
| .metadata-container { | ||
| display: grid; | ||
| grid-template-rows: min-content min-content auto; | ||
| row-gap: 0.5rem; | ||
| } | ||
|
|
||
| .metadata-container hr { | ||
| border: none; | ||
| border-top: 1px solid #e0e0e0; | ||
| margin: 0 1rem; | ||
| width: auto; | ||
| } | ||
|
|
||
| .metadata-filter-container { | ||
| align-items: center; | ||
| column-gap: 0.25rem; | ||
| display: grid; | ||
| grid-template-columns: min-content auto min-content; | ||
| margin: 0.5rem 1rem 0; | ||
| } | ||
| </style> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Styling seems off for the table - it is getting cut off and I can't select any of the rows via checkbox.