Allow Plan Bounds to be Changed#1833
Draft
Mythicaeda wants to merge 6 commits into
Draft
Conversation
- Adds a trigger to cascade boundary changes - Allows snapshots to track and restore plan bounds
- This constraint is no longer necessary now that we have snapshot description to disambiguate identically-named snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a trigger to the Plan table to cascade updates to plan bounds to dependent tables
- specifically:
activity_directive,simulation_dataset, andplan_dataset- simulation bounds are NOT automatically updated by this trigger
- a snapshot is automatically taken when this trigger fires
Adds columns to the Plan Snapshots table to track plan boundaries at the time of snapshot creation
Updates the "Update Plan Revision when Activity Directive is Updated" trigger to not fire if another trigger updates the
activity_directivetableActivity Directiveis from the new trigger on Plan. All other updates to the Activity Directive table are either from function calls (iecommit_merge,delete_activity_by_pk_reanchor_subtree) or via user GQL requestsVerification
TODO
Documentation
Future work