fix: rds bootstrap - #53
Open
aliziel wants to merge 4 commits into
Open
Conversation
…w outside of db for create/alter if exists for easier issue identification + maintenance
aliziel
force-pushed
the
fix/rds-bootstrap
branch
from
July 29, 2026 21:24
63bbe28 to
311be89
Compare
aliziel
commented
Jul 29, 2026
| cursor.execute( | ||
| sql.SQL( | ||
| "ALTER USER {username} WITH PASSWORD {password};" | ||
| ).format(username=sql.Identifier(username), password=password) |
Collaborator
Author
There was a problem hiding this comment.
Wanted to note previous concern about parameter binding + injection.
Both .format() and %s look like Python-based string interpolation (unsafe), but these are psycopg methods:
- This version mirrors an example in their
.format()documentation that includes both identifiers and literals - We can also blend with
psycopgserverside parameters, if preferred (see last example in linked section)
aliziel
marked this pull request as ready for review
August 12, 2026 21:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Addresses issues surfaced during initial stack create on EIC:
Changes
Identifieruse on non-identifier parametersIdentifieruse caught theCREATE USERcondition in update commandRETAIN_ON_UPDATE_OR_DELETEPR Checklist
terraform validateandterraform plan