Consistent error messaging for field names in query language#734
Open
al-niessner wants to merge 4 commits intodevelopfrom
Open
Consistent error messaging for field names in query language#734al-niessner wants to merge 4 commits intodevelopfrom
al-niessner wants to merge 4 commits intodevelopfrom
Conversation
Check that given field name in the query language is valid throwing same error when they do not.
jordanpadams
approved these changes
Mar 9, 2026
jordanpadams
approved these changes
Mar 12, 2026
jordanpadams
requested changes
Mar 16, 2026
service/src/main/java/gov/nasa/pds/api/registry/model/Antlr4SearchListener.java
Outdated
Show resolved
Hide resolved
tloubrieu-jpl
requested changes
Mar 17, 2026
change requested
sonarqube made me do it
silly sonarqube is just making the code worse not better. runtimeexception is the correct answer, but this holds truth in that if the state of the system is not repaired, the same error will continue to occur.
|
Member
|
@al-niessner @tloubrieu-jpl do we have any idea why these branch actions are running in what appears to be an infinite loop? |
Contributor
Author
|
@jordanpadams Nope. |
Member
|
@al-niessner when you have a chance, can you please try to debug what is going on with the integration tests? We cannot merge any of these updates without the integration tests integrating successfully or at least understand why it is hanging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



🗒️ Summary
Treat specific field names the same as wildcard field names.
🤖 AI Assistance Disclosure
Estimated % of code influenced by AI: ___ %
⚙️ Test Data and/or Report
Automated tests should work as they cover this code block already.
♻️ Related Issues
#712
🤓 Reviewer Checklist
Reviewers: Please verify the following before approving this pull request.
Documentation and PR Content
Security & Quality
Testing & Validation
Maintenance