Conversation
|
@jordanpadams @tloubrieu-jpl @nutjob4life Y'all are gonna hate me for this. Wrote a script to do the work locally. It saves a JSON file with information to tell github actions if there was success or not. Solves the small action resources even as tests grow. Keeps enforcing testing. Yes, can fake it, but can fake anything. For instance, postman was returning success despite having 12 assertion failures . Turns out the return status is not all that reliable. Have to do some log parsing. Minimal today, but can improve as it evolves. |
nutjob4life
left a comment
There was a problem hiding this comment.
Hah! Wow, this is … actually pretty nifty, @al-niessner. But I think it could use some docs as well, since the CI itself is now "part of the official record" (git history) with the last_integration_test.json file, and there are some new motions developers have to go through:
- README update: explain what
last_integration_test.json, when it must be updated, how, what GitHub Actions is actually checking - Maybe this repo should have its own
.github/pull_request_template.mdwith an extra checkbox reminding people to do that?
| # The EXIT pseudo-signal covers normal exits, errors, and interruptions (Ctrl+C) | ||
| trap 'rm -rf "$tdir"' EXIT | ||
| cd "$tdir" || exit 1 | ||
| git clone --quiet https://github.com/NASA-PDS/registry.git |
There was a problem hiding this comment.
Is this okay? It looks like we're just cloning HEAD and so makes this repository dependent on whatever the state of registry happens to be at the time.
I'm okay with that—just want to double-check.
The JSON is regenerated when you run .github/workflows/integration_tests.sh. No manual editing of the JSON file. Question is, do you add a commit hook (no because there is a fixed 8 minute wait in there for reasons I cannot fathom) or something similar. Maybe the push. However, until working robustly and quickly, just do it manually. May need to move the script to make it more obvious - I would suggest a script to call this script because this script pretends it knows where it is. Oh docs. Sure... |
Ohh I missed that. Sorry. Docs for the win! |
Need to add similar content to readme.md but it is most important here because the developer will be trying to understand why github actions is giving a red X to find the solution in the github actions output.
|



🗒️ Summary
Pulled the testing from actions to local machine but verify that it has been run and successful in actions. Cheater and inexpensive off loading...
🤖 AI Assistance Disclosure
Estimated % of code influenced by AI: ___ %
⚙️ Test Data and/or Report
All tests should pass
♻️ Related Issues
Closes #744
Closes #745
🤓 Reviewer Checklist
Reviewers: Please verify the following before approving this pull request.
Documentation and PR Content
Security & Quality
Testing & Validation
Maintenance