Skip to content

Seperate cesm preview namelists out#395

Draft
ekluzek wants to merge 13 commits into
NCAR:mainfrom
ekluzek:seperate_cesm_preview_namelists_out
Draft

Seperate cesm preview namelists out#395
ekluzek wants to merge 13 commits into
NCAR:mainfrom
ekluzek:seperate_cesm_preview_namelists_out

Conversation

@ekluzek
Copy link
Copy Markdown
Collaborator

@ekluzek ekluzek commented Mar 6, 2026

Description of changes:

  • Please add an explanation of what your changes do and why you'd like us to include them.

This is preliminary work on moving the cesm postprocessing script into a preview_namelists section and a runtime section.

This is work on #371
Also add #399 here as well

All PRs Checklist:

  • Have you followed the guidelines in our Contributor's Guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you made sure that the pre-commit checks passed (#8 in Adding Notebooks Guide)?
  • Have you successfully tested your changes locally when running standalone CUPiD?
  • Have you tested your changes as part of the CESM workflow? Tested, but currently fails
  • Once you are ready to have your PR reviewed, have you changed it from a Draft PR to an Open PR?

CESM_CUPID=${SRCROOT}/tools/CUPiD
CUPID_ROOT=`./xmlquery --value CUPID_ROOT`
CUPID_EXAMPLE=`./xmlquery --value CUPID_EXAMPLE`
CUPID_GEN_TIMESERIES=`./xmlquery --value CUPID_GEN_TIMESERIES`
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnlevy1981 points out that we should have a shared script used by both, that does these initial steps here, something about cesm_import_xml_vars.sh.

With it being executed something like...

. ./cesm_import_xml_vars.sh

It could also be made into a subroutine and exercised that way.

mkdir -p cupid-postprocessing
cd cupid-postprocessing

# If CUPID_RUN_ALL is TRUE, we don't add any component flags.
Copy link
Copy Markdown
Collaborator Author

@ekluzek ekluzek Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this section doesn't need to be here.

@@ -0,0 +1,185 @@
#!/bin/bash -e
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In talking with @mnlevy1981 we thought the name should be something like:

cesm_generate_cupid_config_files.sh

# and then update this to python as well (and take a CIME Case object as
# an argument)
set -x

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem I was seeing with this for the conda environment, might be explained by adding a

. ./env_mach_specific.sh

call here to make sure the environment is setup as it's needed to be for the CESM case. This is something that's done in the case.cupid script in the CASEROOT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants