Skip to content

Fix the standard deviation in the sea ice contour plots.#403

Open
dabail10 wants to merge 3 commits into
NCAR:mainfrom
dabail10:seaice
Open

Fix the standard deviation in the sea ice contour plots.#403
dabail10 wants to merge 3 commits into
NCAR:mainfrom
dabail10:seaice

Conversation

@dabail10
Copy link
Copy Markdown
Collaborator

@dabail10 dabail10 commented Apr 17, 2026

Description of changes:

This addresses issue #402. Turns out that I needed nanstd. Also tweak the colormaps and mask.

All PRs Checklist:

  • Have you followed the guidelines in our Contributor's Guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you made sure that the pre-commit checks passed (#8 in Adding Notebooks Guide)?
  • Have you successfully tested your changes locally when running standalone CUPiD?
  • Have you tested your changes as part of the CESM workflow?
  • Once you are ready to have your PR reviewed, have you changed it from a Draft PR to an Open PR?

New notebook PR Additional Checklist (if these do not apply, feel free to remove this section):

  • Have you hidden the code cells (#8 in Adding Notebooks Guide) in your notebook?
  • Have you removed any unused parameters from your cell tagged with parameters? These can cause confusing warnings that show up as DAG build with warnings.
  • Have you moved any observational data that you are using to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data and ensured that it follows this format within that directory: COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE?

edit [MNL]: removed superfluous checkbox from description section

@dabail10 dabail10 requested review from duvivier and mnlevy1981 April 17, 2026 20:00
Copy link
Copy Markdown
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I know np.nanstd() fixed the issue with vmin and vmax, and I like how the arguments were cleaned up (listing vmin before vmax and passing [constant]*field_std instead of "field_std*[constant])

@dabail10
Copy link
Copy Markdown
Collaborator Author

@duvivier Can you take a quick look at this?

Copy link
Copy Markdown
Collaborator

@duvivier duvivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants