Fix floating-point exception error in ShinHong PBL#18
Open
weiwangncar wants to merge 3 commits intoNCAR:mainfrom
Open
Fix floating-point exception error in ShinHong PBL#18weiwangncar wants to merge 3 commits intoNCAR:mainfrom
weiwangncar wants to merge 3 commits intoNCAR:mainfrom
Conversation
Collaborator
Author
|
@dudhia @Songyou184 Can you review this PR? |
dudhia
approved these changes
Apr 30, 2026
mgduda
reviewed
Apr 30, 2026
| deltaz=0.5*(z(k+1)-z(k-1)) | ||
| s2l=s2(k) | ||
| q2l=q2(k) | ||
| q2l=max(q2(k),0.01) |
Collaborator
There was a problem hiding this comment.
How was the lower bound of 0.01 chosen?
Collaborator
There was a problem hiding this comment.
It is just a small value typically used for tke which is what this is. There is a parameter called epsq2l=0.01 that probably should have been used instead.
dudhia
approved these changes
May 6, 2026
…d double precision
dudhia
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation with -D option on Derecho identified possible floating-point exception error in the ShinHong PBL module. This PR sets some limit to prevent this from happening.