Fix H/Z dimensional inconsistency in TAPER_LEITHY depth tapering#427
Merged
alperaltuntas merged 1 commit intoApr 27, 2026
Merged
Conversation
zc was declared [Z ~> m] but filled from h [H ~> m or kg m-2], so the comparison against CS%leithy_depth / CS%leithy_width (both [Z]) mixed units. To fix this, we convert h to dz via thickness_to_dz before accumulating zc.
gustavo-marques
approved these changes
Apr 27, 2026
iangrooms
approved these changes
Apr 27, 2026
Collaborator
iangrooms
left a comment
iangrooms
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing, as well as adding the do loops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zc was declared [Z ~> m] but filled from h [H ~> m or kg m-2], so the comparison against CS%leithy_depth / CS%leithy_width (both [Z]) mixed units. To fix this, we convert h to dz via thickness_to_dz before accumulating zc.
Fixes: #426