Rrfs support hi pr 3.1 by donaldwj · Pull Request #129 · NCAR/WrfHydroForcing

donaldwj · 2025-12-19T16:49:52Z

No description provided.

…uerto Rico domains. Includes new code and configuration files. Tested on WCOSS2.

donaldwj

This is still the code that was inital submitted for 3.1. I think the retroactive 3.0 update erased parts of this somehow. core/forcingInputMod had the 3.0 setup and 3.1 config files were missing

Copilot

Pull request overview

This PR adds support for RRFS (Rapid Refresh Forecast System) forcing data for three regional domains: North America (NA), Puerto Rico (PR), and Hawaii (HI). The changes introduce new input forcing options (keys 24-26), corresponding regridding functions, and configuration templates for each region.

Adds three new RRFS regional forcing options with domain-specific configurations
Implements time-handling and regridding functions for RRFS NA, PR, and HI domains
Updates forcing input module to support new GRIB variables and output mappings
Provides configuration templates for operational use on WCOSS systems

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 36 comments.

Show a summary per file

File	Description
core/time_handling.py	Adds neighbor-finding functions for RRFS NA, PR, and HI domains to calculate temporal interpolation windows
core/regrid.py	Implements regridding functions for each RRFS domain with GRIB2-to-NetCDF conversion and spatial interpolation
core/forcingInputMod.py	Updates forcing definitions to add CPOFP variable and extend output mappings for new RRFS products
Template/template_forcing_engine.config	Documents new RRFS forcing options (24-26) in configuration template
Config/WCOSS/v3.1/template_forcing_engine_PuertoRico_RRFS_Short.config	New configuration for Puerto Rico short-range RRFS forecasts
Config/WCOSS/v3.1/template_forcing_engine_PuertoRico_RRFS_Analysis.config	New configuration for Puerto Rico RRFS analysis runs
Config/WCOSS/v3.1/template_forcing_engine_Medium_GFS-NDFD.config	Adds RegridWeightsDir configuration option
Config/WCOSS/v3.1/template_forcing_engine_Hawaii_RRFS_Short.config	New configuration for Hawaii short-range RRFS forecasts
Config/WCOSS/v3.1/template_forcing_engine_Hawaii_RRFS_Analysis.config	New configuration for Hawaii RRFS analysis runs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-07T17:01:15Z

core/time_handling.py


+def find_rrfs_na_neighbors(input_forcings, config_options, d_current, mpi_config):
+    """
+    Function to calculate the previous and after HRRR conus cycles based on the current timestep.


The docstring incorrectly refers to 'HRRR conus cycles' when this function is for RRFS NA. Update to 'RRFS NA cycles'.

Suggested change

Function to calculate the previous and after HRRR conus cycles based on the current timestep.

Function to calculate the previous and after RRFS NA cycles based on the current timestep.

Copilot · 2026-01-07T17:01:15Z

core/time_handling.py

+    :return:
+    """
+    if mpi_config.rank == 0:
+        config_options.statusMsg = "Processing Conus HRRR Data. Calculating neighboring " \


The status message refers to 'Conus HRRR Data' but this function processes RRFS NA data. Update to 'Processing RRFS NA Data'.

Suggested change

config_options.statusMsg = "Processing Conus HRRR Data. Calculating neighboring " \

config_options.statusMsg = "Processing RRFS NA Data. Calculating neighboring " \

Copilot · 2026-01-07T17:01:16Z

core/time_handling.py

+    default_horizon = 18  # 18-hour forecasts.
+    six_hr_horizon = 84  # 84-hour forecasts every six hours.
+
+    # First find the current HRRR forecast cycle that we are using.


Comment references 'HRRR forecast cycle' but should reference 'RRFS forecast cycle' for consistency with the function's purpose.

Copilot · 2026-01-07T17:01:16Z

core/time_handling.py

+        err_handler.log_critical(config_options, mpi_config)
+    err_handler.check_program_status(config_options, mpi_config)
+
+    # Calculate the current forecast hour within this HRRR cycle.


Comment incorrectly references 'HRRR cycle' instead of 'RRFS cycle'.

Copilot · 2026-01-07T17:01:16Z

core/time_handling.py

+    input_forcings.fcst_date2 = next_rrfs_date
+
+    # Calculate the output forecast hours needed based on the prev/next dates.
+    dt_tmp = next_hrrr_date - current_rrfs_cycle


Variable name 'next_hrrr_date' is inconsistent - should be 'next_rrfs_date' to match the RRFS context and the variable defined at line 764.

Suggested change

dt_tmp = next_hrrr_date - current_rrfs_cycle

dt_tmp = next_rrfs_date - current_rrfs_cycle

Copilot · 2026-01-07T17:01:25Z

core/regrid.py

+        return
+
+    # Create a path for a temporary NetCDF file
+    input_forcings.tmpFile = config_options.scratch_dir + "/" + "NAM_NEST_TMP-{}.nc".format(mkfilename())


Temporary file name uses 'NAM_NEST_TMP' prefix but this function handles RRFS HI data. Update to 'RRFS_HI_TMP' for consistency.

Suggested change

input_forcings.tmpFile = config_options.scratch_dir + "/" + "NAM_NEST_TMP-{}.nc".format(mkfilename())

input_forcings.tmpFile = config_options.scratch_dir + "/" + "RRFS_HI_TMP-{}.nc".format(mkfilename())

Copilot · 2026-01-07T17:01:25Z

core/forcingInputMod.py

                'UGRD_10maboveground', 'VGRD_10maboveground',
-                'APCP_surface', 'DSWRF_surface', 'DLWRF_surface'],
+                'APCP_surface', 'DSWRF_surface', 'DLWRF_surface',
+                'PRES_surface'],


Inconsistent array formatting compared to similar entries (24-26). Line 391 ends with a closing bracket and comma while lines 395, 399, and 403 continue the array definition. This entry (23) should follow the same pattern as 24-26.

Suggested change

'PRES_surface'],

'PRES_surface', 'CPOFP_surface'],

Copilot · 2026-01-07T17:01:25Z

Config/WCOSS/v3.1/template_forcing_engine_PuertoRico_RRFS_Short.config

+# 19 - HRRR GRIB2 Alaska production files
+# 20 - ExtAna HRRR AK FE output
+# 24 - RRFS NA
+# 25 - RRFA HI


Corrected spelling of 'RRFA' to 'RRFS'.

Suggested change

# 25 - RRFA HI

# 25 - RRFS HI

Copilot · 2026-01-07T17:01:26Z

Config/WCOSS/v3.1/template_forcing_engine_PuertoRico_RRFS_Short.config

+# 25 - RRFA HI
+# 26 - RRFS PR


Comment ordering is inconsistent - line 48 shows '25 - RRFA HI' (should be RRFS HI) and line 49 shows '26 - RRFS PR', but this is a Puerto Rico config file using InputForcings = [26]. The comment at line 47 shows '24 - RRFS NA'. Consider reordering or clarifying the documentation.

Suggested change

# 25 - RRFA HI

# 26 - RRFS PR

# 25 - RRFS HI

# 26 - RRFS PR (Puerto Rico; used by this configuration)

Copilot · 2026-01-07T17:01:26Z

Config/WCOSS/v3.1/template_forcing_engine_Hawaii_RRFS_Short.config

+BDateProc = syyyymmdy0000
+EDateProc = eyyyymmdy0000


Date format appears to be placeholder text ('syyyymmdy0000' and 'eyyyymmdy0000') rather than valid date format. Should be in YYYYMMDDHHMM format as noted in comment at line 107, e.g., 202412230000.

Suggested change

BDateProc = syyyymmdy0000

EDateProc = eyyyymmdy0000

BDateProc = 202412230000

EDateProc = 202412231200

rcabell · 2026-01-14T21:14:13Z

@donaldwj do we still need this PR? and would it be cleaner to undo the previous PR (#128) and reapply the v3.0.18 RRFS code?

donaldwj added 7 commits September 24, 2025 16:07

This is the inital code for RRFS Forcing support for the Hawaii and P…

80d0009

…uerto Rico domains. Includes new code and configuration files. Tested on WCOSS2.

Remove typo.

6308270

Fix deleted row 6, and refactor location of new code in regrid.py

bc42860

add files not added to previous commit.

d475b43

Fixed error in Netcdf_names table.

945a422

profile updates from Cham

bf6b428

Merge branch 'main' into rrfs_support_hi_pr_3.1

c88f319

donaldwj commented Dec 19, 2025

View reviewed changes

rcabell requested review from Copilot and rcabell January 7, 2026 16:56

Copilot AI reviewed Jan 7, 2026

View reviewed changes

	Function to calculate the previous and after HRRR conus cycles based on the current timestep.
	Function to calculate the previous and after RRFS NA cycles based on the current timestep.

	config_options.statusMsg = "Processing Conus HRRR Data. Calculating neighboring " \
	config_options.statusMsg = "Processing RRFS NA Data. Calculating neighboring " \

	dt_tmp = next_hrrr_date - current_rrfs_cycle
	dt_tmp = next_rrfs_date - current_rrfs_cycle

	input_forcings.tmpFile = config_options.scratch_dir + "/" + "NAM_NEST_TMP-{}.nc".format(mkfilename())
	input_forcings.tmpFile = config_options.scratch_dir + "/" + "RRFS_HI_TMP-{}.nc".format(mkfilename())

Conversation

donaldwj commented Dec 19, 2025

Uh oh!

donaldwj left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

Uh oh!

rcabell commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants