Skip to content

Ufs-dev pr350#685

Merged
grantfirl merged 7 commits intoNCAR:mainfrom
hertneky:ufs-dev-PR350
May 5, 2026
Merged

Ufs-dev pr350#685
grantfirl merged 7 commits intoNCAR:mainfrom
hertneky:ufs-dev-PR350

Conversation

@hertneky
Copy link
Copy Markdown
Collaborator

@hertneky hertneky commented Apr 21, 2026

This PR catches the NCAR:main branch up with changes from the ufs-community:ufs/dev branch. SCM RTs passed for ursa_gnu

Associated ufs/dev PR:

Associated ufsatm PR:

Associated NCAR PR:


REGRESSION TEST CHANGES:

Comment thread ccpp/suites/suite_SCM_GFS_v17_p8_ps.xml Outdated
@hertneky
Copy link
Copy Markdown
Collaborator Author

@grantfirl Sorry for the delay - finally got around to fixing the submodule pointer. This is ready now.

@hertneky hertneky requested a review from grantfirl April 23, 2026 15:54
Copy link
Copy Markdown
Member

@scrasmussen scrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@grantfirl
Copy link
Copy Markdown
Collaborator

RT baselines changed for gfortran/Release/supported, but they are insignificant and near precision level. Not sure why it happened, but it shouldn't be a problem.

@grantfirl
Copy link
Copy Markdown
Collaborator

RT baselines changed for gfortran/Release/supported, but they are insignificant and near precision level. Not sure why it happened, but it shouldn't be a problem.

Note that this is the second PR in a row where we got baseline differences that appear to be compiler optimization related with our RT setup. I.e. Debug tests are b4b whereas Release tests are not and have miniscule differences. I hope this doesn't become a theme...

@grantfirl grantfirl merged commit 033bf6b into NCAR:main May 5, 2026
18 checks passed
@dustinswales
Copy link
Copy Markdown
Member

RT baselines changed for gfortran/Release/supported, but they are insignificant and near precision level. Not sure why it happened, but it shouldn't be a problem.

Note that this is the second PR in a row where we got baseline differences that appear to be compiler optimization related with our RT setup. I.e. Debug tests are b4b whereas Release tests are not and have miniscule differences. I hope this doesn't become a theme...

It seems to be a GNU issue, which is less tested across SDFs in the UFS.

I don't think GFS_v16 physics with GNU in release mode is ever tested in the UWM. I just went through tests/rt.conf in the UWM, and only one GNU test uses GFS_v16, control_stochy_debug, which is a debug test, and should pass w/ lower optimazation

I know that GFS_v16_RRTMGP is not tested with GNU at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants