If a role is duplicated and only one has a group, do not include the duplicate. - #434
Open
amandasinha wants to merge 2 commits into
Open
If a role is duplicated and only one has a group, do not include the duplicate.#434amandasinha wants to merge 2 commits into
amandasinha wants to merge 2 commits into
Conversation
amandasinha
marked this pull request as ready for review
August 3, 2026 19:40
bcarlsenca
reviewed
Aug 6, 2026
| @@ -157,6 +157,10 @@ export class Concept { | |||
| this.roles = new Array(); | |||
| if (input.roles) { | |||
| for (let i = 0; i < input.roles.length; i++) { | |||
Contributor
There was a problem hiding this comment.
What you're doing here may work for your examples, but the logic is not quite right. There may be more than one that has different groups. What you want to do is have a "key" that takes into account the "identity" of the role independently of the group. Internally the java hashcode function uses relatedCode,relatedName,type,source. So the idea is to put them into a set based on a hash key and then extract that back to a list. something like this
const key = o => JSON.stringify([o.relatedCode, o.relatedName, o.source, o.type]);
this.roles = [...new Map(input.roles.map(o => [key(o), o])).values()];
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.