Skip to content

PVA/EVSRESTAPI-728: dockerize evsrestapi - #492

Open
peter-va wants to merge 24 commits into
developfrom
PVA/EVSRESTAPI-728-dockerize-evs-applications
Open

PVA/EVSRESTAPI-728: dockerize evsrestapi#492
peter-va wants to merge 24 commits into
developfrom
PVA/EVSRESTAPI-728-dockerize-evs-applications

Conversation

@peter-va

Copy link
Copy Markdown
Collaborator

Dockerizing the evsrestapi app. Also contains vulnerability fixes and a slight tweak to make scan/scandocker to fix parsing the html for vulnerabilities

@peter-va
peter-va requested a review from bcarlsenca July 31, 2026 22:18
@peter-va peter-va changed the title dockerize evsrestapi PVA/EVSRESTAPI-730: dockerize evsrestapi Aug 4, 2026
@peter-va peter-va changed the title PVA/EVSRESTAPI-730: dockerize evsrestapi PVA/EVSRESTAPI-728: dockerize evsrestapi Aug 5, 2026

@bcarlsenca bcarlsenca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This advice is probably going to apply to the other docker projects too. But look at how termhub-auth-service does it (or wci-mapping-service). One key thing is that gradle should be run WITHIN the docker image, not on the local machine and brought in after-the fact. Everything should be isolated from any local build setup.

The other thing to pay attention to is to have "docker build" and "docker push" use --platform linux/amd64 . Windows does this automatically but not when you run on a mac and the images will need to run on a linux server (for which this also works).

Also I see you have these make file things for "-strict". I don't think we need those things. We run scan manually and then check the reports - otherwise they run in a strict way via github workflow actions - so there's no need for that at the top level.

@peter-va

peter-va commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

@bcarlsenca made some changes to the docker images based on your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants