PVA/EVSRESTAPI-728: dockerize evsrestapi - #492
Conversation
bcarlsenca
left a comment
There was a problem hiding this comment.
This advice is probably going to apply to the other docker projects too. But look at how termhub-auth-service does it (or wci-mapping-service). One key thing is that gradle should be run WITHIN the docker image, not on the local machine and brought in after-the fact. Everything should be isolated from any local build setup.
The other thing to pay attention to is to have "docker build" and "docker push" use --platform linux/amd64 . Windows does this automatically but not when you run on a mac and the images will need to run on a linux server (for which this also works).
Also I see you have these make file things for "-strict". I don't think we need those things. We run scan manually and then check the reports - otherwise they run in a strict way via github workflow actions - so there's no need for that at the top level.
…://github.com/NCIEVS/evsrestapi into PVA/EVSRESTAPI-728-dockerize-evs-applications
|
@bcarlsenca made some changes to the docker images based on your feedback |
Dockerizing the evsrestapi app. Also contains vulnerability fixes and a slight tweak to make scan/scandocker to fix parsing the html for vulnerabilities