Merged
Conversation
blairlearn
force-pushed
the
ticket/79-sockets
branch
from
1d49b69 to
acbb6ee
Compare
There was a problem hiding this comment.
Pull request overview
This pull request addresses a socket exhaustion issue by updating the version constraints for NCI.OCPL.Api.Common and NCI.OCPL.Api.Common.Testing dependencies from exact version "3.0.0" to wildcard "3.*" to allow automatic adoption of the latest 3.x versions that include the socket exhaustion fix.
Changes:
- Updated NCI.OCPL.Api.Common package version constraint from "3.0.0" to "3.*" in both source and test projects
- Updated NCI.OCPL.Api.Common.Testing package version constraint from "3.0.0" to "3.*" in the test project
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/NCI.OCPL.Api.BestBets/NCI.OCPL.Api.BestBets.csproj | Updated NCI.OCPL.Api.Common package version to use wildcard pattern "3.*" instead of exact version "3.0.0" |
| test/NCI.OCPL.Api.BestBets.Tests/NCI.OCPL.Api.BestBets.Tests.csproj | Updated both NCI.OCPL.Api.Common and NCI.OCPL.Api.Common.Testing package versions to use wildcard pattern "3.*" instead of exact version "3.0.0" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bump API common nuget packages to 3.0.1 Fixes #79
blairlearn
force-pushed
the
ticket/79-sockets
branch
from
acbb6ee to
46914f8
Compare
bryanpizzillo
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow shared libraries to be latest 3.* version.
Fixes #79