(#4815) Fix PDQ phpstan issues

[bkline]

In pdq_cancer_information_summary/src/OrphanCleanup.php:

• remove line of code inadvertently copied from another method
• reassure PHP (and phpstan) that we have the the right interface for invoking deleteRevision()

Closes #4815

[bryanpizzillo]

@blairlearn what is the status of this?

[blairlearn]

From Teams conversation

Blair
The "phpstan for PDQ" PR -- #4923

The change looks good to me, and I've done some simple testing.
But against the bigger picture of the CDR going away, that's been the extent of it.

(i.e. I've not asked Bob to send edited summaries.)

Bryan
I think we are actually going to merge this during the feature branch work. Basically it should get tested with Summary transforms...

[welshja]

To test, we'll need to get this onto an ODE and then run the new loader to confirm that things work as expected and all summaries are loaded with no crazy errors/fires/natural disasters. (Orphaned cleanup part of the loading process runs without issue.)

[cgdp-management-server]

ODE Deployment

Code has been deployed to ODE 1091.

[welshja]

@jfrank-nih to check with @blairlearn in terms of any testing steps to review on the ODE where it is currently deployed.

[welshja]

Tested on ODE1091 with CIS/DIS loader workflows. Cleanup still working as expected.

To test:
Cancer Info Summaries:

1. Gave site admin login PDQ Importer permissions on ODE with this code installed on it.
2. Ran CIS loader for on ODE with this change for two summaries (62915 256720)
3. Created 22 revisions for 62915 and 3 for the 256720
4. Re-ran loader
5. Checked that only last 3 (current + 2 previous) revisions exist and older ones were cleaned up

Drug Info Summaries:

1. Gave site admin login PDQ Importer permissions on ODE with this code installed on it.
2. Ran CIS loader for on ODE with this change for two summaries (813502 817456)
3. Created 11 revisions for 813502 and 5 for the 817456
4. Re-ran loader
5. Checked that only last 3 (current + 2 previous) revisions exist

[welshja]

Looking good to me after testing