Skip to content

(#2105) Updates modal component events#2106

Merged
olitharp-nci merged 1 commit intodevelopfrom
ticket/2105-updates-to-modal
Feb 20, 2026
Merged

(#2105) Updates modal component events#2106
olitharp-nci merged 1 commit intodevelopfrom
ticket/2105-updates-to-modal

Conversation

@dlescarbeau
Copy link
Contributor

@dlescarbeau dlescarbeau commented Jan 28, 2026

  • removes events for overlap and escape key close
  • custom close event now passes the close action to the event details

Closes #2105

Author PR Checklist

Items that the author of the PR is responsible for checking before submitted the PR.

General:

  • I have reviewed the acceptance criteria defined in the ticket and ensured the work has been completed.
  • The commit message passes all quality commit message standards.
  • Unit tests have been updated or created to reflect any javascript changes.
  • Storybook scenarios have been updated or created to reflect any html/css/js changes.

Accessibility:

  • WCAG 2.1 Level AA requirements have been met.

Development:

  • Any new or updated javascript code has 100% unit test coverage.
  • New or updated breakpoints have regression images.
  • Breaking changes have been thoroughly documented in the PR.

Product Reviewer PR Checklist

Items the product team is responsible for reviewing.

General:

  • There are no unexpected or unapproved regression image changes.

  • Functionality of interactive elements meet the acceptance criteria.
  • The product is visually and functionally the same across the different browsers.

Accessibility:

  • AxeDev Tools: there are no new or outstanding accessibility issues introduced in this PR.
  • Lighthouse: scores have not noticeably decreased during this PR.
  • Wave: there are no new errors or contrast errors introduced in this PR.

Design Reviewer PR Checklist

Items the design team is responsible for reviewing. 


General:

  • New or updated features introduced in this PR are developed mobile-first.
  • Breakpoint changes and regression images match those breakpoints.
  • This PR has been tested in all supported browsers at all breakpoints.

Developer Reviewer PR Checklist

Items the development team is responsible for reviewing.

General:

  • New code passes code quality standards set by industry standards.
  • The expected Storybook stories have been added or updated for the new or updated feature.
  • The expected unit tests have been added or updated for the new or updated feature.

Accessibility:

  • VoiceOver: Described content matches with what was expected.
  • Keyboard navigation: new or updated features and content are navigable via the keyboard.

@github-actions
Copy link

@dlescarbeau dlescarbeau force-pushed the ticket/2105-updates-to-modal branch 3 times, most recently from d4894fd to 92f0735 Compare February 3, 2026 19:23
Copy link

@adrianacastaneda adrianacastaneda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Reviewed that the modal worked correctly on both the documentation site and storybook PR links

@bennettcc bennettcc requested review from a team February 18, 2026 20:41
@dlescarbeau dlescarbeau force-pushed the ticket/2105-updates-to-modal branch from 92f0735 to 30799db Compare February 19, 2026 15:49
@dlescarbeau dlescarbeau force-pushed the ticket/2105-updates-to-modal branch 2 times, most recently from dddb8e5 to bb11866 Compare February 20, 2026 16:44
- removes events for overlap and escape key close
- custom close event now passes the close action to the event details

Closes #2105

(#2105) Updates modal component events

- removes events for overlap and escape key close
- custom close event now passes the close action to the event details

Closes #2105
@dlescarbeau dlescarbeau force-pushed the ticket/2105-updates-to-modal branch from bb11866 to 287256a Compare February 20, 2026 16:46
@olitharp-nci olitharp-nci merged commit 569cc97 into develop Feb 20, 2026
7 of 8 checks passed
@olitharp-nci olitharp-nci deleted the ticket/2105-updates-to-modal branch February 20, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modal Issues

5 participants