(#2105) Updates modal component events#2106
Merged
olitharp-nci merged 1 commit intodevelopfrom Feb 20, 2026
Merged
Conversation
Viewing Information |
d4894fd to
92f0735
Compare
adrianacastaneda
approved these changes
Feb 17, 2026
adrianacastaneda
left a comment
There was a problem hiding this comment.
Looks good. Reviewed that the modal worked correctly on both the documentation site and storybook PR links
92f0735 to
30799db
Compare
andyvanavery31
approved these changes
Feb 19, 2026
karlikpj
approved these changes
Feb 19, 2026
olitharp-nci
requested changes
Feb 20, 2026
packages/ncids-js/src/components/usa-modal/event-details/modal.open.event-details.ts
Outdated
Show resolved
Hide resolved
dddb8e5 to
bb11866
Compare
- removes events for overlap and escape key close - custom close event now passes the close action to the event details Closes #2105 (#2105) Updates modal component events - removes events for overlap and escape key close - custom close event now passes the close action to the event details Closes #2105
bb11866 to
287256a
Compare
olitharp-nci
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2105
Author PR Checklist
Items that the author of the PR is responsible for checking before submitted the PR.
General:
Accessibility:
Development:
Product Reviewer PR Checklist
Items the product team is responsible for reviewing.
General:
Accessibility:
Design Reviewer PR Checklist
Items the design team is responsible for reviewing.
General:
Developer Reviewer PR Checklist
Items the development team is responsible for reviewing.
General:
Accessibility: