(#2107) Implement ShadowDOM Config Option for Modal#2108
Draft
dlescarbeau wants to merge 2 commits intodevelopfrom
Draft
(#2107) Implement ShadowDOM Config Option for Modal#2108dlescarbeau wants to merge 2 commits intodevelopfrom
dlescarbeau wants to merge 2 commits intodevelopfrom
Conversation
Viewing Information |
bebb505 to
49412c8
Compare
- removes events for overlap and escape key close - custom close event now passes the close action to the event details Closes #2105 (#2105) Updates modal component events - removes events for overlap and escape key close - custom close event now passes the close action to the event details Closes #2105
10caf0a to
a67ca50
Compare
- Allows the modal to be isolated from the rest of the page Closes #2107
a67ca50 to
c3058e9
Compare
Contributor
Author
|
This PR changes the modal so that its config can take a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Adds a config option for passing the modal a shadow root, allowing the modal styles to be separated from the rest of the page. This will be utilized by the CIS Slider so we do not have to worry about conflicting versions of the NCIDS.
Closes #2107
Author PR Checklist
Items that the author of the PR is responsible for checking before submitted the PR.
General:
Accessibility:
Development:
Product Reviewer PR Checklist
Items the product team is responsible for reviewing.
General:
Accessibility:
Design Reviewer PR Checklist
Items the design team is responsible for reviewing.
General:
Developer Reviewer PR Checklist
Items the development team is responsible for reviewing.
General:
Accessibility: