Skip to content

fix(status): fail closed when the baseline cannot identify the binary #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rldyourmnd merged 1 commit into from
Aug 1, 2026
Merged

fix(status): fail closed when the baseline cannot identify the binary #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cli-tools/nddev_mimocode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5586,7 +5586,14 @@ def software_status(target: Path, *, include_cleanup: bool = True) -> dict[str,
drift.append("asset_sha256")
if info.get("asset_size") != expected_size:
drift.append("asset_size")
# The extracted-binary identity is the only check that survives an attacker
# who rewrites the manifest, because the manifest sits beside the binary and
# is equally writable. A baseline that omits it therefore cannot answer
# "is this the software we installed" at all -- so say so instead of
# skipping the check and still reporting current.
executable_baseline = asset.get("executable")
if not isinstance(executable_baseline, dict):
drift.append("baseline_executable_unavailable")
if isinstance(executable_baseline, dict):
for key in (
"archive_member_path",
Expand Down
Loading