Skip to content

Fix heartbeat ticker stopping after unsuccessful connection #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martialblog merged 1 commit into from
Jul 13, 2026
Merged

Fix heartbeat ticker stopping after unsuccessful connection #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/gc/gc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ func (g *GarbageCollector) heartbeat(ctx context.Context) {

if errSvc != nil {
g.logger.Error("Could not fetch heartbeat service from Icinga", "component", "gc", "error", errSvc.Error())
return
// Skip this tick, we will try next time
continue
}

action := icinga2.Action{
Expand All @@ -152,7 +153,8 @@ func (g *GarbageCollector) heartbeat(ctx context.Context) {

if errProcess != nil {
g.logger.Error("Could not process-check-result for heartbeat", "component", "gc", "error", errProcess.Error())
return
// Skip this tick, we will try next time
continue
}

g.logger.Info("Successfully sent heartbeat to Icinga", "component", "gc", "service", g.serviceName)
Expand Down