Skip to content

Refactor result package #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RincewindsHat wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Refactor result package #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8107d62
Refactor result package
Jun 15, 2026
392079e
Rename internal struct to better reflect purpose
Jun 15, 2026
4f88ecb
Remove useless error checks
Jun 15, 2026
2f24af1
Merge branch 'main' into refactor_result
Jun 15, 2026
695b062
Fix linter issues
Jun 15, 2026
0f9f5b7
[squash] small reordering of types and funcs
martialblog Jun 15, 2026
2041c5e
[squash] Remove unecessary nolint and error return
martialblog Jun 15, 2026
47469b8
Implement generic status compare function and short worst with it
Jun 15, 2026
ae04351
examples: slight code improvements
Jun 15, 2026
9b58bb2
Status: Fix Compare function and add tests
Jun 15, 2026
e97784c
Remove stateful summary from overall check object
Jun 15, 2026
f3c8eef
Remove leftover comment
Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/check_example/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ func TestMyMain(t *testing.T) {
expected = "[OK] - value is 10"

if !strings.Contains(actual, expected) {
t.Fatalf("expected %v, got %v", expected, actual)
t.Fatalf("expected %q, got %q", expected, actual)
}

actual = testhelper.RunMainTest(main, "--warning", "10", "--value", "11")
expected = "[WARNING] - value is 11"

if !strings.Contains(actual, expected) {
t.Fatalf("expected %v, got %v", expected, actual)
t.Fatalf("expected %q\n, got %q", expected, actual)
}
}

Expand Down
19 changes: 6 additions & 13 deletions examples/check_example2/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,22 @@ func main() {

var overall result.Overall

check1 := result.PartialResult{}
check1 := result.NewPartialResult()

check1.Output = "Check1"
err := check1.SetState(check.OK)

if err != nil {
check.ExitError(err)
}
check1.SetState(check.OK)

check1.Perfdata.Add(&perfdata.Perfdata{
Label: "foo",
Value: 23,
})

check2 := result.PartialResult{}
overall.AddSubcheck(check1)

check2.Output = "Check2"
err = check2.SetState(check.Warning)
check2 := result.NewPartialResult()

if err != nil {
check.ExitError(err)
}
check2.Output = "Check2"
check2.SetState(check.Warning)

check2.Perfdata.Add(&perfdata.Perfdata{
Label: "bar",
Expand All @@ -43,7 +37,6 @@ func main() {
Value: 46,
})

overall.AddSubcheck(check1)
overall.AddSubcheck(check2)

check.Exit(overall.GetStatus(), overall.GetOutput())
Expand Down
4 changes: 2 additions & 2 deletions examples/check_example2/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
func TestMyMain(t *testing.T) {
actual := testhelper.RunMainTest(main)

expected := `[WARNING] - states: warning=1 ok=1
expected := `[WARNING] - Check2
\_ [OK] Check1
\_ [WARNING] Check2
|foo=23 bar=42 'foo2 bar'=46
Expand All @@ -19,7 +19,7 @@ would exit with code 1
`

if actual != expected {
t.Fatalf("expected %v, got %v", expected, actual)
t.Fatalf("expected %q\n, got %q", expected, actual)
}
}

Expand Down
Loading
Loading