Add support for skybox settings, sound settings and room behavior enums values#326
Open
Yanis002 wants to merge 1 commit intoNEstelami:masterfrom
Open
Add support for skybox settings, sound settings and room behavior enums values#326Yanis002 wants to merge 1 commit intoNEstelami:masterfrom
Yanis002 wants to merge 1 commit intoNEstelami:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this adds support for the different values of skybox settings, sound settings and room behavior commands, builds OK for both games (note: on OoT the
SkyboxConfigenum doesn't exist but I decided to add the values in the xml data instead, this way whenever this is documented ZAPD won't need an extra update there)I'm not sure if a ZAPD update is planned on both repos so I was thinking of opening PRs to add the new enums in the xml, though let me know if it's fine to make the update in code too
oot: https://github.com/Yanis002/oot/tree/more_enums
mm: https://github.com/Yanis002/mm/tree/more_enums