Landuse history update superPR merge#1529
Conversation
…r LUC-associated fire
…anduse-merge-1407-1485
github-project-automation
Bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
|
Regression testing is underway on |
| if (((ccohort%c_area + crown_area_covered)/cpatch%area) .ge. 0.05_r8 ) then | ||
| hio_patch_weighted_95thpctile_height_si(io_si) = & | ||
| hio_patch_weighted_95thpctile_height_si(io_si) + ccohort%height * cpatch%area/AREA | ||
| ccohort => null() ! exit the cohort loop |
There was a problem hiding this comment.
This is an interesting way to break out of a linked list loop. Have we used this type of operation before? Seems like a good way to do it.
| ! =============================================================================================== | ||
|
|
||
|
|
||
| subroutine update_history_hifrq_landuse(this,nc,nsites,sites,bc_in,dt_tstep) |
There was a problem hiding this comment.
Love the use of a new routine here
|
|
||
| cpatch => sites(s)%oldest_patch | ||
| do while(associated(cpatch)) | ||
| if (cpatch%total_canopy_area .gt. rsnbl_math_prec) then |
There was a problem hiding this comment.
Why is this compared against the math precision value? It is being mulitplied, so zero should be fine in this case. Is this to differentiate between an initialized and non-initialized value?
Shouldn't we be filering for canopy_area_bylanduse(...) > 0?
|
Closing this PR as I realized that it's mixing two fates PR, one of which needs to be coordinated with the HLM update. #1485 does not need to be coordinated and will be brought in on it's own. |
3 participants
Description:
This pull request merges #1407 and #1485 into a single pull request as both PRs cover similar conceptual ground, adding multiple new land use history variables.
Collaborators:
Expectation of Answer Changes:
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: