python tool that converts a netcdf parameter file to json#1557
Open
rgknox wants to merge 3 commits into
Open
Conversation
glemieux
requested changes
May 5, 2026
Contributor
glemieux
left a comment
There was a problem hiding this comment.
Thanks for getting this tool going. I have a couple suggested changes and two questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
As the title says, this tool converts a netcdf binary to JSON. It uses xarray as an intermediary.
Collaborators:
@adrifoster
Expectation of Answer Changes:
Description of generative AI usage (as necessary)
Yes, this used generative AI to create the tool from the ground up through conversational design. The tool was then modified to use our write_json script. The logic in the code is not complicated and was reviewed by the author and makes sense. The tool was then tested on existing netcdf binaries.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
FATES PASS/FAIL regression tests were runN/AEvaluation of test results for answer changes was performed and results providedN/AFATES-CLM6 Code Freeze: satellite phenology regression tests are b4bN/AIf satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: