update hydraulic conductivity scaling model#1565
Open
xuchongang wants to merge 5 commits into
Open
Conversation
… to match the scaling for conduit width from Olson 2020
Contributor
|
Thanks Chonggang and really interesting. Should this be in the parameter file, rather than hard-coded though? |
Contributor
Author
Contributor
Author
|
@JunyanDing, @jennykowalcz , @yfang-pnnl , it would be great if you could review. @rgknox, it would be great if you could do some test on the most recent version of FATES! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taper improvement.pdf
This pull request update the petiole length parameter to match the scaling of conduit size from Olson 2020 (https://nph.onlinelibrary.wiley.com/doi/10.1111/nph.16961)
Description:
The original scaling model has a much larger scaling of conduit size compared to the data from Olson 2020. To resolve this issue, I have added a new taper function based on Olson 2020. Please see attached the derivation of the taper components. Our hydraulic model optimization showed that this version of the taper function should be much closer to observations. This could also resolve the issue of size distribution of water potential. By lowering the hydraulic conductivity for taller trees, it will give a higher water stress for larger size of tree and thus higher mortality.
Collaborators:
@bchristo
Expectation of Answer Changes:
By change this values, we will see more reasonable scaling and make the model easier to fit to observed sapflow.
Description of generative AI usage (as necessary)
No AI used.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
No need to change to the documentation.
Test Results:
See attached figures of scaling with the impact of change.
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: