Skip to content

Initialize prescribed fire site-level variables#1567

Open
glemieux wants to merge 1 commit into
NGEET:mainfrom
glemieux:rxfire-init-fix
Open

Initialize prescribed fire site-level variables#1567
glemieux wants to merge 1 commit into
NGEET:mainfrom
glemieux:rxfire-init-fix

Conversation

@glemieux
Copy link
Copy Markdown
Contributor

@glemieux glemieux commented May 8, 2026

Addresses issue #1470

Description:

This initializes rxfire_area_fi and rxfire_area_fuel` which are currently uninitialized on the main branch.

Collaborators:

@samsrabin @XiulinGao @mvdebolskiy

Expectation of Answer Changes:

None, should be B4B

Description of generative AI usage (as necessary)

No AI usage

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary
  • Describe use of generative AI (if necessary)

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux requested a review from samsrabin May 8, 2026 23:14
@glemieux glemieux changed the title Initialize rxfire site-level variables Initialize prescribed fire site-level variables May 8, 2026
@samsrabin samsrabin linked an issue May 11, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@samsrabin samsrabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks—but looking at #1470, what about rxfire_area_final?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Finding Reviewers

Development

Successfully merging this pull request may close these issues.

site%rxfire_area_f* variables never initialized

2 participants