Deactivate history fields in SP mode#1568
Conversation
github-project-automation
Bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
glemieux
moved this from Finding Reviewers
to Under Review
in FATES Pull Request Planning and Status
|
Love this change |
| call this%set_history_var(vname='FATES_FROOTC', units='kg m-2', & | ||
| long='total biomass in live plant fine roots in kg carbon per m2', & | ||
| use_default='active', avgflag='A', vtype=site_r8, hlms='CLM:ALM', & | ||
| use_default=trim(drop_in_sp), avgflag='A', vtype=site_r8, hlms='CLM:ALM', & |
There was a problem hiding this comment.
These allometric C structure variables are, I think, relevant/used in SP mode. The cohort is defined based on the height and the other pools are set accordingly. So there should be valid values for VEGC, SAPWOODC, FROOTC, STRUCTC, NONSTRUCTC
| call this%set_history_var(vname='FATES_VEGC_PF', units='kg m-2', & | ||
| long='total PFT-level biomass in kg of carbon per land area', & | ||
| use_default='active', avgflag='A', vtype=site_pft_r8, hlms='CLM:ALM', & | ||
| use_default=trim(drop_in_sp), avgflag='A', vtype=site_pft_r8, hlms='CLM:ALM', & |
There was a problem hiding this comment.
This should exist in SP mode.
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't think we calculate it though.
WHen in SP or ST3 mode, we perform a bypass of the whole allocation algorithm:
https://github.com/NGEET/fates/blob/main/main/EDMainMod.F90#L1133
Without calling it, there is no VEGC. We could certainly improve the bypass though to set VEGC to allometric targets though....
| call this%set_history_var(vname='FATES_LAI_CANOPY_SZ', units = 'm2 m-2', & | ||
| long='leaf area index (LAI) of canopy plants by size class', & | ||
| use_default='active', avgflag='A', vtype=site_size_r8, & | ||
| use_default=trim(drop_in_sp), avgflag='A', vtype=site_size_r8, & |
There was a problem hiding this comment.
In principle the plants in SP mode do have a height and and LAi and so in theory this has some meaning...
There was a problem hiding this comment.
But there is only one size ("SZ") right? I see this diagnostic as not wrong, just unneeded with SP.
|
|
||
| call this%set_history_var(vname='FATES_NPLANT_SZ', units = 'm-2', & | ||
| long='number of plants per m2 by size class', use_default='active', & | ||
| long='number of plants per m2 by size class', use_default=trim(drop_in_sp), & |
There was a problem hiding this comment.
This might also be useful as a diagnostic to check that the plants are coming out in the right size class given HTOP...
rosiealice
left a comment
rosiealice
left a comment
There was a problem hiding this comment.
Looks great @mvdebolskiy ... Thanks for pushing this back.
|
@rosiealice I don't quite get the comments. If the variables there "should be active" why are they exluded in the |
Fair enough. It's not critical either way. I guess i just didn't think about these reasons for keeping them last time I went through the variable list (I realize I'm critiquing my own earlier classification effort here, so should have been clearer about that :) ) . |
Fix gnu integer logical
4 participants
Use a bool switch to deactivate default fields in SP-mode, so that on the HLM-side long hist_fexl* are not used.
Description:
See above
Collaborators:
@rgknox @glemieux
Expectation of Answer Changes:
For SP-test a few extra fields will be deactivated, since f.e. in CTSM tests, the FATES-SP usermod has not been updated in a while.
Description of generative AI usage (as necessary)
None.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
Only field list will change for SP tests with:
Tested with ctsm's
FatesColdSatPhentestmod. with commenting out exclude in the fates-sp usermod vs default tag. Test withFatesColdand removing hist_fincl and empty_tapes showed no diffs.*CTSM (or) E3SM (specify which) test hash-tag: ctsm5.4.038
*CTSM (or) E3SM (specify which) baseline hash-tag: ctsm5.4.038
*FATES baseline hash-tag: sci.1.92.4_api.45.0.0
Test Output: