Skip to content

sanitize geopackage path and change print statements to log statments#71

Closed
danielcumpton wants to merge 1 commit intomainfrom
ngwpc-9962_sanitize_inputs
Closed

sanitize geopackage path and change print statements to log statments#71
danielcumpton wants to merge 1 commit intomainfrom
ngwpc-9962_sanitize_inputs

Conversation

@danielcumpton
Copy link

[Short description explaining the high-level reason for the pull request]

Additions

The temporary path for storing a subset geopackage uses the id from the API input in the filename. This was sanitized by only allowing letters and numbers, normalizing the path, and checking against the already defined temp directory root.

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@danielcumpton danielcumpton requested a review from dylanlee March 19, 2026 19:40
@danielcumpton danielcumpton self-assigned this Mar 19, 2026
@dylanlee
Copy link

This branch has changes that were included in PR #73 closing PR

@dylanlee dylanlee closed this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants