Use nwm-ewts repository ngen integration code for the logger and log bridge#164
Merged
cmaynard-ngwpc merged 23 commits intodevelopmentfrom Mar 25, 2026
Merged
Use nwm-ewts repository ngen integration code for the logger and log bridge#164cmaynard-ngwpc merged 23 commits intodevelopmentfrom
cmaynard-ngwpc merged 23 commits intodevelopmentfrom
Conversation
EWTS versions to build summary output to console Updates to CMakeLists.txt for integrating the nwm-ewts libraries Initial conversion to ewts_ngen_bridge library. Updated CMakeLists. Replaced logMsgAndThrowError with separate calls to LOG and throw.
ewts_ngen/logger.hpp is included in public headers, so the EWTS include directories must propagate to downstream consumers (tests, etc). PRIVATE linkage caused 'ewts_ngen/logger.hpp: No such file' when compiling test targets.
cmaynard-ngwpc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update submodule references to point to their development branches containing the upgrade using the nwm-ewts libraries.
Updated ngen to use the nwm-ewts ngen integration code and log bridge to control logging.
Removed the old logger.
Dockerfile updated to build with the new ewts library.