Sfincs Creator and Realization Implementation#63
Open
mkarim-rtx wants to merge 9 commits intophilmiller-coastal-schismfrom
Open
Sfincs Creator and Realization Implementation#63mkarim-rtx wants to merge 9 commits intophilmiller-coastal-schismfrom
mkarim-rtx wants to merge 9 commits intophilmiller-coastal-schismfrom
Conversation
PhilMiller
changed the base branch from
philmiller-coastal-schism_ngwpc_7037_7241_7242_7243
to
philmiller-coastal-schism
zhengtaocui
reviewed
Mar 10, 2026
| endif() | ||
| endforeach() | ||
|
|
||
| # Also exclude the SCHISM coastal test if present in the repo |
There was a problem hiding this comment.
Is this because the schism test doesn't work?
Author
There was a problem hiding this comment.
yes, in my environment. We can discuss if we need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBD
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support