Skip to content

Add first draft CONUS test cases#79

Closed
sclaw wants to merge 179 commits intomasterfrom
nhf-routing
Closed

Add first draft CONUS test cases#79
sclaw wants to merge 179 commits intomasterfrom
nhf-routing

Conversation

@sclaw
Copy link

@sclaw sclaw commented Feb 24, 2026

This PR adds a new test to the nhf test suite with a CONUS-wide dataset. This test runs t-route for a portion of the 2022 US summer floods over all of CONUS. Channel forcing data is retrieved from National Water Model 3.0 retrospective data. This test is more a test of the nhf data than of t-route code. For that reason, these tests should not be run in the default pytest test set. The test_nhf_conus function has therefore been marked as an integration test.

Additions

  • test/nhf/conus/make_forcing.py
  • test/nhf/conus/README.md
  • test/nhf/test_conus.py

Removals

  • None

Changes

  • None

Testing

  1. Issues with nhf 0.4.1 prevented t-route from running on the test dataset.

Screenshots

Notes

  • Due to the large size of both the CONUS nhf and the channel forcing data for t-route, no data has been included in this PR. Users should copy nhf to their local machine and follow the instructions in test/nhf/conus/README.md to create the dataset and setup the test directory.
  • One of the existing tests was failing, and no attempt has been made to resolve it. test_hyfeatures_network.py fails because lake_id field is not available. Tadd noted this here: patch: fixed broken lower colorado test #31. This test should be removed. Line 138 (nexus) also broken for that test. yuqiong e3a4998

Todos

  • Issues with nhf 0.4.1 prevented t-route from running on the test dataset. Once the issues are resolved, the simulation time-window may be adjusted to better match event start and end times.
  • More tests are needed to determine if the t-route run for this is successful, once the nhf 0.4.1 issue is resolved.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • [] Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

ngwpcareg and others added 30 commits October 8, 2024 12:02
@ngwpcareg
customization of t-route's logging class to comply with logging requi…
c18012a 
…rements set in NGWPC-3888
@ngwpcareg
some log message formatting change
64d2630
@ngwpcareg
Merge branch 'NGWPC-3888' into 'development'
d75d7ef 
customization of t-route's logging class to comply with logging requirements set in NGWPC-3888

See merge request NGWPC/nwm-ngen/t-route!1
@cmaynard-ngwpc
Text file containing repository version number and date
42c992c
@ngwpcareg
Logger optimizations
872da97
@ngwpcareg
Merge remote-tracking branch 'origin/development' into NGWPC-3888
95effcd
@cmaynard-ngwpc
Update date in version.txt file
df32bf5
@cmaynard-ngwpc
Update release in version.txt file
51b7e61
@zhengtaocui
Merge branch 'NGWPC-3888' into 'development'
6061c18 
Ngwpc 3888

See merge request NGWPC/nwm-ngen/t-route!2
@cmaynard-ngwpc
Removed version, date. Added commit field. No official release has be…
e51ce1d 
…en done yet.
changes to make t-route compatible with v2.2 gpkg
7ccccab
@cmaynard-ngwpc
Merge branch 'cmaynard_NGWPC-4611_version_file' into 'development'
7f43ee7 
Text file containing repository version number and date

See merge request NGWPC/nwm-ngen/t-route!3
@peterkronenberg-rtx
Merge branch 'yliu_NGPWC-2750_hfv2.2_changes' into 'development'
ba6935b 
changes to make t-route compatible with v2.2 gpkg

See merge request NGWPC/nwm-ngen/t-route!4
@cmaynard-ngwpc
Merge branch 'development' into 'release-candidate'
998a8e1 
Development Branch Merge to release-candidate branch for version text file

See merge request NGWPC/nwm-ngen/t-route!5
@cmaynard-ngwpc
Updated version file for rc-1.0.0
2b9368a
@cmaynard-ngwpc
Merge branch 'release_rc-1.0.0_update_version_file' into 'release-can…
2f3802d 
…didate'

Updated version file for Release rc-1.0.0

See merge request NGWPC/nwm-ngen/t-route!6
@cmaynard-ngwpc
Merge branch 'release-candidate' into 'master'
57e1195 
Release Candidate Branch Merge to main for Release 1.0.0

See merge request NGWPC/nwm-ngen/t-route!7
@cmaynard-ngwpc
update version file for release 1.0.0
888a811
@cmaynard-ngwpc
Merge branch 'update-version-number' into 'master'
7be508c 
update version file for release 1.0.0

See merge request NGWPC/nwm-ngen/t-route!8
@cmaynard-ngwpc
Merge branch 'master' into 'development'
981d873 
Release 1.0.0 Merge to development

See merge request NGWPC/nwm-ngen/t-route!9
@cmaynard-ngwpc
Added RTX licensing verbiage
d67450d
@cmaynard-ngwpc
Merge branch 'add_rtx_licencing' into 'development'
b17c9a7 
Added RTX licensing verbiage

See merge request NGWPC/nwm-ngen/t-route!11
@cmaynard-ngwpc
Merge branch 'development' into 'release-candidate'
1a5a6f9 
Merge development into release-candidate for release rc-1.1.0

See merge request NGWPC/nwm-ngen/t-route!12
@cmaynard-ngwpc
Update version file for release rc-1.1.0 on 2025-02-12
93dd243
@cmaynard-ngwpc
Merge branch 'update_version_file_rc-1.1.0' into 'release-candidate'
e2d5c84 
Merge update_version_file_rc-1.1.0 into release-candidate for release rc-1.1.0

See merge request NGWPC/nwm-ngen/t-route!13
@cmaynard-ngwpc
Merge branch 'release-candidate' into 'development'
829d9e1 
Merge release-candidate into development for release rc-1.1.0

See merge request NGWPC/nwm-ngen/t-route!14
@cmaynard-ngwpc
Merge branch 'release-candidate' into 'master'
a8a27c2 
Merge release-candidate into master for release 1.1.0

See merge request NGWPC/nwm-ngen/t-route!15
@cmaynard-ngwpc
Update version file for release 1.1.0 on 2025-02-25
16e7f2b
@cmaynard-ngwpc
Merge branch 'update_version_file_1.1.0' into 'master'
1037e8c 
Merge update_version_file_1.1.0 into master for release 1.1.0

See merge request NGWPC/nwm-ngen/t-route!16
@cmaynard-ngwpc
Merge branch 'master' into 'development'
2462eb9 
Merge master into development for release 1.1.0

See merge request NGWPC/nwm-ngen/t-route!17
idtodd and others added 29 commits October 7, 2025 12:33
@idtodd
Prevent reading nexus file when running through BMI
4d87377
@idtodd
Fill out BMI functionality
1ac4d37
@idtodd
Merge branch 'development' into run-t-route-through-bmi
6e59665
@idtodd
Set logging info on model creation
9028c86
@idtodd
Add timings logs
079c9ec
@idtodd
Filter waterbodies timesteps to top of the hour
64f0715
@idtodd
Remove testing code
a486c6d
@idtodd
Redesign empty waterbody timestep creation
546908d
@idtodd
Simplify empty waterbody timestep creation
fdda2c4
@idtodd
Ensure seconds is type int
a59a610
@cmaynard-ngwpc
Merge pull request #44 from NGWPC/run-t-route-through-bmi
a39fd5c 
Drive NGEN T-Route through BMI (NGWPC-7700)
@idtodd
Remove Network function that reads nexus files for metadata
1bd8e3c
@idtodd
Add more logging and timing info
55f2acb
@idtodd
Static BMI values for counts; set value copies input data
2f73ca8
@cmaynard-ngwpc
Merge pull request #47 from NGWPC/idt-remove-nexus-file-read-from-bmi
0c1e4d2 
Remove nexus file read in BMI implementation (NGWPC-8769)
@mxkpp
Unify pydantic minimum version to currently latest patch release of 2.11
46d4dfa
@mxkpp
Merge pull request #50 from NGWPC/maxkipp-ngwpc-8941-upgrade-shapely-2
a17017f 
Unify pydantic minimum version to currently latest patch release of 2.11 (2.11.9)
@taddyb
merge: merging in rfc-channel loss
3fad399
@taddyb
merge: merged channel loss into developement
6d9d61b
@taddyb
merge: merging usbr persistence
009ab2f
@taddyb
merge: merging in rnr
c35f79e
@taddyb
merge: merging development
80c8065
@taddyb
tests: added test case for conecuh river test case (#57)
d0bdd34
@taddyb
Ngwpc 8461: added the NHF dataset integration and flow-scaling (#61)
ff45933 
* tests: added test case for conecuh river test case (#57)

* feat: created outline of structure needed for v5 routing

* feat: created outline of structure needed for v5 routing

* tmp: read geo file and preprocessing network

* patch: updated domain gpkg file, finished preprocessing in init

* tmp: test

* added lateral flow functions

* tests: added flowpath scaling test
@taddyb
NGWPC 8465: Added unit tests for flow-scaling (#63)
8c8e183 
* tests: added test case for conecuh river test case (#57)

* feat: created outline of structure needed for v5 routing

* feat: created outline of structure needed for v5 routing

* tmp: read geo file and preprocessing network

* patch: updated domain gpkg file, finished preprocessing in init

* tmp: test

* added lateral flow functions

* tests: added flowpath scaling test

* feat: troute connections are working

* feat: made internals of the network testable

* patch: missing trailing ticks in readme

* added python command to readme
@taddyb
feat: updated the view_output.ipynb with flow-scaling verification
1055f6e
@taddyb
patch: added text to notebook explaining flow and flow-scaling
f6ec7db
@taddyb
nit: added a new flow animation
4b3a980
@dylanlee
Merge branch 'pi-8-NGWPC-8442' into nhf-routing
378d1f2
@sclaw sclaw closed this Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.