Add T-Route NHF Compatibility by sclaw · Pull Request #86 · NGWPC/t-route

sclaw · 2026-03-24T12:27:46Z

This PR updates the NHF implementation in t-route to achieve the following

Fully align lateral flow additions and flow scaling approach with OWP guidance
Implement a reach discretization scheme within t-route such that flowpaths can be merged and split into routing links with more consistent and hydraulically-appropriate lengths.
Refactor and rewrite NHF code in t-route to allow the method to scale to CONUS
Update testing suite to account for three two changes
Update BMI to account for these three changes

This code has been compared to the NWM v3.0 retrospective data for a December 2009 event in the Conecuh River and achieved reasonable agreement with the retrospective results.

Further work should be done to test this method at the CONUS scale.

* customization of t-route's logging class to comply with logging requirements set in NGWPC-3888 * some log message formatting change * Text file containing repository version number and date * Logger optimizations * Update date in version.txt file * Update release in version.txt file * Removed version, date. Added commit field. No official release has been done yet. * changes to make t-route compatible with v2.2 gpkg * Updated version file for rc-1.0.0 * update version file for release 1.0.0 * Added RTX licensing verbiage * Update version file for release rc-1.1.0 on 2025-02-12 * Update version file for release 1.1.0 on 2025-02-25 * Delete version.txt * PI4 feature integration tests (#8) * added integration tests * removed api data * removed duplicate test * updated LICENSE * PI4 feature unit test updates (#9) * added t-route unit tests * removing outdated tests * upate LICENSE * Pi4 running troute using HF v2.2 (#10) * added files for RnR enhancements to the API, test data, docs * removed unneccessary files, updated LICENSE * JIRA 5916: Port forecast formatting code into T-Route RnR workspace package (#11) * initial commit * patch: updated functions to make code more testable. Added error handling * pr changes * changing name of variable in main to be consistent * feat: pydantic updates * fix: commited pydantic changes too soon --------- Co-authored-by: Quercus <quercus.hamlin@outlook.com> * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * JIRA 5920: Integrating the RnR domain logic into `troute-rnr` (#13) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * JIRA 5917: Replacing the T-Route RnR API with a namespace package (#14) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * removed API * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * ensuring merge-conflict is resolved properly and code works * JIRA 5918: Validate t-route runs with testing (#15) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * added tests for the t-route formatting * got restart test working * updated examples * added new test figure * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * JIRA 5917: Replacing the T-Route RnR API with a namespace package (#14) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * removed API * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * ensuring merge-conflict is resolved properly and code works * added tests for the t-route formatting * got restart test working * removed unneccessary csvs * Jira 5919: Validate T-Route outputs against the max inundation file (#16) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * added tests for the t-route formatting * got restart test working * updated examples * adding post_process script for rnr formatting * saving output file * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * JIRA 5917: Replacing the T-Route RnR API with a namespace package (#14) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * removed API * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * ensuring merge-conflict is resolved properly and code works * JIRA 5918: Validate t-route runs with testing (#15) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * added tests for the t-route formatting * got restart test working * updated examples * added new test figure * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * JIRA 5917: Replacing the T-Route RnR API with a namespace package (#14) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * removed API * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * ensuring merge-conflict is resolved properly and code works * added tests for the t-route formatting * got restart test working * removed unneccessary csvs * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * added tests for the t-route formatting * got restart test working * Update log filename handling. Change defalult Python levels ERROR->SEVERE, CRITICAL->FATAL * added uv version of compiler.sh (#17) * added uv version of compiler.sh * removing icefabric from dependencies. Will provide wheels * Patch: remove aws s3 cred references (#18) * added uv version of compiler.sh * removing icefabric from dependencies. Will provide wheels * removed S3/boto3 aws reliance * removed a boto3 reference * Patch 05162025 (#19) * removed redis, fixed copy/paste error * patching post process script and pyyaml imports to ensure code works * PATCH: remove print from settings * Made parsing Gages_ case-insensitive * Patch 06052025: Adding clearer error statements, and solving WFOs which are out of CONUS (#20) * patch: solved error for missing reach id * solved num_messages bug * Update main.py (#21) * JIRA 6401: Formatting the output.csv file in based on OWP suggestions (#22) * updated post_processing to include filtering by time * added a function to format the .nc files after creation to contain RFC metadata * reformatted the post_process file to be what OWP specified * Added a try/catch for t-route (#23) * patch: adding prints for error handling to except value erros * added finally statement to ensure messages are acknowledged * Convert some stdout print msgs to ngen log entries * adding valueError to skip units other than kcfs * adding try-except format to read_rfc_flows * fixed t-route missing hl_link/id/hl_uri * fixed t-route missing hl_link/id/hl_uri * Revert "adding valueError to skip units other than kcfs" This reverts commit 3c36558. * Revert "Revert "adding valueError to skip units other than kcfs"" This reverts commit 97316ce. * Revert "adding valueError to skip units other than kcfs" This reverts commit 3c36558. * Revert " adding try-except format to read_rfc_flows" This reverts commit 8477ad8. * patch: added ValueError handling for incorrect stage * Expose reservoir_assimilation_value to the BMI interface * manually merged hllink fixes * Remove copy/paste error * Fix Downcasting object FutureWarning * Fix HybridParameters and PreprocessingParameters PydanticSerializeUnexpectedValue warnings * Remove unnecessary forward reference double quotes * Remove setuptools-scm from pyproject.toml # Conflicts: # src/troute-config/pyproject.toml * Fix pydantic version in t-route config * Fix hl_reference gpkg layer for lakeout Converted legacy log statements to EWTS log statements --------- Co-authored-by: areg.amirkhanian <areg.amirkhanian@rtx.com> Co-authored-by: Carolyn.Maynard <carolyn.maynard@rtx.com> Co-authored-by: Zhengtao Cui <zhengtao.cui@rtx.com> Co-authored-by: Parallel Works app-run user <yuqiong.liu@mgmt-yuqiongliu-nwmeval-00057.testawsuseast1-1.pw.local> Co-authored-by: Peter Kronenberg <peter.a.kronenberg@rtx.com> Co-authored-by: Quercus <quercus.hamlin@outlook.com> Co-authored-by: Kyle Larkin <kyle.larkin@U-2U1H90H2EWXD5.nextgenwaterprediction.com> Co-authored-by: Kyle Larkin <klarkin@css-inc.com> Co-authored-by: Farshid Rahmani <farshid.rahmani@U-1BVT2XY7DCIBM.nextgenwaterprediction.com> Co-authored-by: yuqiong.liu <yuqiong.liu@ertcorp.com> Co-authored-by: Farshid Rahmani <farshid368@gmail.com>

…servoir flows within the persistence model (#25) * feat: added USBR support for T-route and reservoir persistence modeling * feat: added test subcase for USBR reservoir routing * fix: saved jupyter notebook outputs * fix: renamed test to persistence * fix: patching whitespace

* customization of t-route's logging class to comply with logging requirements set in NGWPC-3888 * some log message formatting change * Text file containing repository version number and date * Logger optimizations * Update date in version.txt file * Update release in version.txt file * Removed version, date. Added commit field. No official release has been done yet. * changes to make t-route compatible with v2.2 gpkg * Updated version file for rc-1.0.0 * update version file for release 1.0.0 * Added RTX licensing verbiage * Update version file for release rc-1.1.0 on 2025-02-12 * Update version file for release 1.1.0 on 2025-02-25 * Delete version.txt * PI4 feature integration tests (#8) * added integration tests * removed api data * removed duplicate test * updated LICENSE * PI4 feature unit test updates (#9) * added t-route unit tests * removing outdated tests * upate LICENSE * Pi4 running troute using HF v2.2 (#10) * added files for RnR enhancements to the API, test data, docs * removed unneccessary files, updated LICENSE * JIRA 5916: Port forecast formatting code into T-Route RnR workspace package (#11) * initial commit * patch: updated functions to make code more testable. Added error handling * pr changes * changing name of variable in main to be consistent * feat: pydantic updates * fix: commited pydantic changes too soon --------- Co-authored-by: Quercus <quercus.hamlin@outlook.com> * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * JIRA 5920: Integrating the RnR domain logic into `troute-rnr` (#13) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * JIRA 5917: Replacing the T-Route RnR API with a namespace package (#14) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * removed API * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * ensuring merge-conflict is resolved properly and code works * JIRA 5918: Validate t-route runs with testing (#15) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * added tests for the t-route formatting * got restart test working * updated examples * added new test figure * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * JIRA 5917: Replacing the T-Route RnR API with a namespace package (#14) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * removed API * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * ensuring merge-conflict is resolved properly and code works * added tests for the t-route formatting * got restart test working * removed unneccessary csvs * Jira 5919: Validate T-Route outputs against the max inundation file (#16) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * added tests for the t-route formatting * got restart test working * updated examples * adding post_process script for rnr formatting * saving output file * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * JIRA 5917: Replacing the T-Route RnR API with a namespace package (#14) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * removed API * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * ensuring merge-conflict is resolved properly and code works * JIRA 5918: Validate t-route runs with testing (#15) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * added tests for the t-route formatting * got restart test working * updated examples * added new test figure * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * JIRA 5917: Replacing the T-Route RnR API with a namespace package (#14) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added icefabric hooks to get shortest paths on demand * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * moved troute run out of the format file * removed API * updated troute-config to move to pydantic v2 (#12) * updated troute-config to move to pydantic v2 * fixed incorrect pyproject * patch: forgot to upload a change in the data assimilation file * fixed incorrect pyproject * missed model rebuild * added comments for why typing tests were removed * ensuring merge-conflict is resolved properly and code works * added tests for the t-route formatting * got restart test working * removed unneccessary csvs * added legacy rnr code for formatting input flows * adding t-route support from rnr inputs * added tests for the t-route formatting * got restart test working * Update log filename handling. Change defalult Python levels ERROR->SEVERE, CRITICAL->FATAL * added uv version of compiler.sh (#17) * added uv version of compiler.sh * removing icefabric from dependencies. Will provide wheels * Patch: remove aws s3 cred references (#18) * added uv version of compiler.sh * removing icefabric from dependencies. Will provide wheels * removed S3/boto3 aws reliance * removed a boto3 reference * Patch 05162025 (#19) * removed redis, fixed copy/paste error * patching post process script and pyyaml imports to ensure code works * PATCH: remove print from settings * Made parsing Gages_ case-insensitive * Patch 06052025: Adding clearer error statements, and solving WFOs which are out of CONUS (#20) * patch: solved error for missing reach id * solved num_messages bug * Update main.py (#21) * JIRA 6401: Formatting the output.csv file in based on OWP suggestions (#22) * updated post_processing to include filtering by time * added a function to format the .nc files after creation to contain RFC metadata * reformatted the post_process file to be what OWP specified * Added a try/catch for t-route (#23) * patch: adding prints for error handling to except value erros * added finally statement to ensure messages are acknowledged * Convert some stdout print msgs to ngen log entries * adding valueError to skip units other than kcfs * adding try-except format to read_rfc_flows * fixed t-route missing hl_link/id/hl_uri * fixed t-route missing hl_link/id/hl_uri * Revert "adding valueError to skip units other than kcfs" This reverts commit 3c36558. * Revert "Revert "adding valueError to skip units other than kcfs"" This reverts commit 97316ce. * Revert "adding valueError to skip units other than kcfs" This reverts commit 3c36558. * Revert " adding try-except format to read_rfc_flows" This reverts commit 8477ad8. * patch: added ValueError handling for incorrect stage * Expose reservoir_assimilation_value to the BMI interface * manually merged hllink fixes * Remove copy/paste error * Fix Downcasting object FutureWarning * Fix HybridParameters and PreprocessingParameters PydanticSerializeUnexpectedValue warnings * Remove unnecessary forward reference double quotes * Remove setuptools-scm from pyproject.toml # Conflicts: # src/troute-config/pyproject.toml * Fix pydantic version in t-route config * Fix hl_reference gpkg layer for lakeout Converted legacy log statements to EWTS log statements --------- Co-authored-by: areg.amirkhanian <areg.amirkhanian@rtx.com> Co-authored-by: Carolyn.Maynard <carolyn.maynard@rtx.com> Co-authored-by: Zhengtao Cui <zhengtao.cui@rtx.com> Co-authored-by: Parallel Works app-run user <yuqiong.liu@mgmt-yuqiongliu-nwmeval-00057.testawsuseast1-1.pw.local> Co-authored-by: Peter Kronenberg <peter.a.kronenberg@rtx.com> Co-authored-by: Quercus <quercus.hamlin@outlook.com> Co-authored-by: Kyle Larkin <kyle.larkin@U-2U1H90H2EWXD5.nextgenwaterprediction.com> Co-authored-by: Kyle Larkin <klarkin@css-inc.com> Co-authored-by: Farshid Rahmani <farshid.rahmani@U-1BVT2XY7DCIBM.nextgenwaterprediction.com> Co-authored-by: yuqiong.liu <yuqiong.liu@ertcorp.com> Co-authored-by: Farshid Rahmani <farshid368@gmail.com>

* initial commit: implemented forcing reads for ET * feat: added remaining ELOSS and SSOUT code * fix: addressing PR comments

* initial commit: addressed comments from PI-6 Deliverable review from github * fix: removed compiler_uv.sh as UV has been integrated into the base compiler * patch: updating rnr with icefabric segments * fix: pyproject was not importing correctly with icefabric dependencies * patch: fixed legacy icefabric imports

* fix: removed all icefabric dependencies and added rnr subsetting code * patch: added parquet/ sub-folder * patch: added parquet subfolder to post-process script

* feat: added iac entrypoint to troute-rnr * feat: converted iac entrypoint to a arg * docs: updated readme

* patch: added s3fs import only if using IaC * patch: fixed parquet typo and post-processing logic * patch: ensured hydrolocations is not empty when being passed

* patch: updated boto3 version * patch: changed boto3 version

…aram

* fix: removed xarray s3 writes * fix: removed trailing / * fix: writing nc to disk before uploading

idtodd · 2026-03-24T14:27:43Z

Changed the _is_nhf property on the BMI model to a method. This decreases the amount of data needed to store the model during serialization.

idtodd · 2026-03-24T14:34:18Z

Two general notes:

Can we reduce the number of new test files, e.g., test/channel_loss/channel_forcing/et/cat-2619300.csv? We've received comments that the repositories are large enough they can create problems, and these will probably add to that.
For a future update, the logging in new files (e.g., src/troute-nwm/src/nwm_routing/nwm_route.py) need to use the updated EWTS system once that's finalized. I think it's OK to continue using LOG = logging.getLogger("") for this effort as the EWTS update is not completed yet.

… wrong. Refined approach to reporting flows for merged reaches.

… solver. That info is needed to preserve result formatting while enabling qlat bottom additions.

…exist

taddyb and others added 30 commits August 18, 2025 21:17

Pin package versions in requirements.txt

c640211

RFC Channel Loss algorithm implementation (#28)

8cbe335

* initial commit: implemented forcing reads for ET * feat: added remaining ELOSS and SSOUT code * fix: addressing PR comments

patch: fixed broken lower colorado test (#31)

326158b

NGWPC 7009: prepping t-route rnr for test (#30)

cebc049

* fix: removed all icefabric dependencies and added rnr subsetting code * patch: added parquet/ sub-folder * patch: added parquet subfolder to post-process script

NGWPC-6058: added iac entrypoint to troute-rnr (#34)

4a930cd

* feat: added iac entrypoint to troute-rnr * feat: converted iac entrypoint to a arg * docs: updated readme

Patch 091325: typos and logic in postprocessing (#35)

e0ceee2

* patch: added s3fs import only if using IaC * patch: fixed parquet typo and post-processing logic * patch: ensured hydrolocations is not empty when being passed

patch: removed collect (#36)

69162dd

patch: added bucket_name (#37)

1ea19b4

patch: added logging and IaC channel support (#38)

19a38df

patch: changed boto3 location for import in main (#39)

1ae5e76

patch: updated boto3 version (#40)

13323b1

Patch 091725 update boto3 version (#41)

33a6ac4

* patch: updated boto3 version * patch: changed boto3 version

patch: updated iac channel rabbit_mq_endpoint reference

19fbb92

patch: changed mkdir to create parents, added a store_true to --iac p…

72437b4

…aram

patch: added numpy <2 dependency

05be027

patch: changed mkdir to create parents

a093887

feat: added debug logging

cc1d11e

Patc: added debug flag to make log level optional

0ad742b

fix: updated incorrect file reference

a57d10e

fix: removed data dir references

2dbc17a

fix: removed xarray s3 writes (#42)

bfe553d

* fix: removed xarray s3 writes * fix: removed trailing / * fix: writing nc to disk before uploading

merge: merging in rfc-channel loss

3fad399

merge: merged channel loss into developement

6d9d61b

merge: merging usbr persistence

009ab2f

merge: merging in rnr

c35f79e

merge: merging development

80c8065

sclaw added 14 commits March 19, 2026 17:12

fix bug in forcing generation

9684efa

update diagnostics to conform to new NHF fp_link mapping structure.

403b4b7

fix bug in flow scaling scheme

2c55527

add temporary patches for NHF build

37a3cfe

update code for performance when scaling to conus

4c7ed88

add devcontainer setup

7ff8b9c

Merge branch 'development' into pi-9-NGWPC-9982

787b0c0

first cut NHF BMI integration

0fb564f

update conus test readme

d7df09b

Merge branch 'pi-9-NGWPC-9981' into pi-9-NGWPC-9982

e2be5de

debug BMI NHF integration

6dee690

add BMI test runner

ab9e363

Merge branch 'development' into pi-9-NGWPC-9982

ecc7a80

debug after merge

4e575ee

sclaw mentioned this pull request Mar 24, 2026

Pi 9 ngwpc 9981 #85

Closed

Remove _is_nhf BMI model property

8dfe36e

idtodd and others added 12 commits March 24, 2026 10:54

Reintroduce coastal coupling for non-NHF

7065d69

update BMI test runner

1483788

add EWTS logging to NHF

d9ba850

update NHF prints to use EWTS logging

283bb89

fix bugs relating to merged vfps. Their qlats were sometimes assigned…

44f1b0f

… wrong. Refined approach to reporting flows for merged reaches.

update approach to injecting qlat from previous timesteps into the mc…

6adcf0d

… solver. That info is needed to preserve result formatting while enabling qlat bottom additions.

fix bug in diagnostic qlat calcs. Update plotting conditions

3587775

fix bug that was leading to flow drops between run sets

b460da1

create usgs_q column in make_forcing.py even if 00060 column doesn't …

07aa8e4

…exist

fix bug in qlat logging between run sets

168bddb

clean up diagnostics

8da4c94

fix NaN crash in fp outlet crosswalk for chained short merges

595d56c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add T-Route NHF Compatibility#86

Add T-Route NHF Compatibility#86
sclaw wants to merge 129 commits intodevelopmentfrom
pi-9-NGWPC-9982

sclaw commented Mar 24, 2026

Uh oh!

idtodd commented Mar 24, 2026

Uh oh!

idtodd commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sclaw commented Mar 24, 2026

Uh oh!

idtodd commented Mar 24, 2026

Uh oh!

idtodd commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants