Skip to content

Adapt serialization to revised protocol#4

Merged
PhilMiller merged 2 commits intodevelopmentfrom
PhilMiller-8300-fix-protocol
Oct 10, 2025
Merged

Adapt serialization to revised protocol#4
PhilMiller merged 2 commits intodevelopmentfrom
PhilMiller-8300-fix-protocol

Conversation

@PhilMiller
Copy link

@PhilMiller PhilMiller commented Sep 26, 2025

The earlier BMI state saving protocol was not going to be tenable on Fortran due to intent(in) dummy arguments. This revision simplifies the protocol such that SetValue is used for mutating actions, and GetValue/GetValuePtr are used for queries.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller PhilMiller requested a review from idtodd September 26, 2025 17:27
@PhilMiller PhilMiller changed the title Fix serialization protocol Adapt serialization to revised protocol Sep 26, 2025
@PhilMiller PhilMiller force-pushed the PhilMiller-8300-fix-protocol branch from bf4098a to a064751 Compare September 26, 2025 21:49
@PhilMiller PhilMiller merged commit fa4f7e5 into development Oct 10, 2025
@PhilMiller PhilMiller deleted the PhilMiller-8300-fix-protocol branch October 10, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants