Skip to content

Reset Time Signal (NGWPC-9621)#5

Merged
idtodd merged 9 commits intodevelopmentfrom
idt-reset-time
Mar 13, 2026
Merged

Reset Time Signal (NGWPC-9621)#5
idtodd merged 9 commits intodevelopmentfrom
idt-reset-time

Conversation

@idtodd
Copy link

@idtodd idtodd commented Jan 27, 2026

Hindcasting requires the BMI to reset its time to 0 after loading the previous state. This implements the ability to use SetValue with the variable "reset_time" to have the BMI reset its current time. Other than reporting time, the only other thing identified that time is used for is indexing into values loaded on initialization.

Changes

  • SetValue with the variable "reset_time" will reset the model's time step to 0.

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@idtodd idtodd requested a review from sivasankkar January 27, 2026 15:38
@idtodd idtodd self-assigned this Jan 27, 2026
Copy link

@cmaynard-ngwpc cmaynard-ngwpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested in AWS Workspace.

@idtodd idtodd merged commit 6259302 into development Mar 13, 2026
@idtodd idtodd deleted the idt-reset-time branch March 13, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants