Having Consistent RainMelt Value for all Runoff Models#6
Merged
mkarim-rtx merged 1 commit intodevelopmentfrom Mar 11, 2026
Merged
Having Consistent RainMelt Value for all Runoff Models#6mkarim-rtx merged 1 commit intodevelopmentfrom
mkarim-rtx merged 1 commit intodevelopmentfrom
Conversation
…t value to match with atmosphere_water__liquid_equivalent_precipitation_rate
mkarim-rtx
requested review from
jswade-rtx,
sivasankkar,
yuqiong77 and
zhengtaocui
yuqiong77
reviewed
Mar 11, 2026
There was a problem hiding this comment.
Looks good me. Mohammed and I looked at the code together and determined that atmosphere_water__liquid_equivalent_precipitation_rate_out should be assigned to rain, instead of p, since rain is assigned to the input variable 'atmosphere_water__liquid_equivalent_precipitation_rate', and we want atmosphere_water__liquid_equivalent_precipitation_rate_out to be the same as atmosphere_water__liquid_equivalent_precipitation_rate. The original comment in the code that rain and p are the same does not seem to be accurate.
yuqiong77
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.nextgenwaterprediction.com/browse/NGWPC-9963
I found during testing the atmosphere_water__liquid_equivalent_precipitation_rate_out value not matching the input (QINSUR in my case). So updated the implementation to match it.
Updated the Get Value of : atmosphere_water__liquid_equivalent_precipitation_rate_out
Testing
https://confluence.nextgenwaterprediction.com/spaces/NGWPC/pages/90177659/RR+models+Consistent+rain+melt+Output#RRmodelsConsistentrain+meltOutput-TOPMODEL