Skip to content

APPT-2126 - Recalculate appointment statuses when not cancelling bookings on cancel a date range endpoint#1530

Open
ste-banks wants to merge 2 commits intomainfrom
appt-2126/orphan-bookings-when-not-cancelling-them
Open

APPT-2126 - Recalculate appointment statuses when not cancelling bookings on cancel a date range endpoint#1530
ste-banks wants to merge 2 commits intomainfrom
appt-2126/orphan-bookings-when-not-cancelling-them

Conversation

@ste-banks
Copy link
Contributor

@ste-banks ste-banks commented Mar 18, 2026

Description

If not cancelling bookings when hitting the cancel a date range endpoint, we need to perform an appointment status recalculation to ensure these bookings become orphaned. Haven't included a check in the else if statement for the feature toggle being enabled or not as it's not possible to hit that code from the front end if there are bookings and the cancel date range with booking is disabled. Also added a couple of integration tests to ensure these bookings become orphaned when within the cancellation date range.

Fixes # (issue)

Checklist:

  • My work is behind a feature toggle (if appropriate)
  • If my work is behind a feature toggle, I've added a full suite of tests for both the ON and OFF state
  • The ticket number is in the Pull Request title, with format "APPT-XXX: My Title Here"
  • I have ran npm tsc / lint (in the future these will be ran automatically)
  • My code generates no new .NET warnings (in the future these will be treated as errors)
  • If I've added a new Function, it is disabled in all but one of the terraform groups (e.g. http_functions)
  • If I've added a new Function, it has both unit and integration tests. Any request body validators have unit tests also
  • If I've made UI changes, I've added appropriate Playwright and Jest tests
  • If I've added/updated an end-point, I've added the appropriate annotations and tested the Swagger documentation reflects the change

@ste-banks ste-banks marked this pull request as ready for review March 19, 2026 08:37
@ste-banks ste-banks requested a review from jsed-nhs March 19, 2026 10:47
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants