APPT-2107: add sliding cache implementation to get all sites#1533
Open
APPT-2107: add sliding cache implementation to get all sites#1533
Conversation
|
jsed-nhs
reviewed
Mar 19, 2026
|
|
||
| public async Task<T> GetCacheValue<T>(string cacheKey, CacheOptions<T> options) | ||
| { | ||
| if (memoryCache.TryGetValue<CacheObject<T>>(cacheKey, out var value)) |
Contributor
There was a problem hiding this comment.
We're not taking a SemaphoreSlim lock on this method, is that intentional?
jsed-nhs
reviewed
Mar 19, 2026
| internal async Task UpdateSiteInCacheAsync(string siteId) | ||
| { | ||
| if (options.Value.DisableSiteCache) | ||
| if (options.Value.SlidingCacheEnabled) |
Contributor
There was a problem hiding this comment.
Could we name this something else, as it only represents enablement for GetAllSites rather than generally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to performance concerns we're introducing Sliding Cache for get all sites. I made this change in a way that we can move back to the basic caching if we need to in the future
Fixes # (issue)
Checklist: