Skip to content

NPA-4831: Update Sandbox with Examples for _includes Patient Details When Multiple Proxy Relationships#199

Merged
ellie-bound1-NHSD merged 4 commits into
masterfrom
dev/NPA-4831/Update-Sandbox-with-Examples-for-Includes-Patient-Detials-Multiple-Relationships
May 2, 2025
Merged

NPA-4831: Update Sandbox with Examples for _includes Patient Details When Multiple Proxy Relationships#199
ellie-bound1-NHSD merged 4 commits into
masterfrom
dev/NPA-4831/Update-Sandbox-with-Examples-for-Includes-Patient-Detials-Multiple-Relationships

Conversation

@ellie-bound1-NHSD

@ellie-bound1-NHSD ellie-bound1-NHSD commented May 2, 2025

Copy link
Copy Markdown
Contributor

Pull Request

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-4831

Description/Change Summary

  • Added 3 new examples to specification
  • Added 3 new scenarios to sandbox and detailed them in the specification doc

How to test?

  • Updated unit tests in sandbox
  • Updates to postman to follow

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@ellie-bound1-NHSD ellie-bound1-NHSD self-assigned this May 2, 2025
@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4831

@ellie-bound1-NHSD ellie-bound1-NHSD force-pushed the dev/NPA-4831/Update-Sandbox-with-Examples-for-Includes-Patient-Detials-Multiple-Relationships branch from 8322c3f to 473ad23 Compare May 2, 2025 10:51
@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4831

@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4831

@JackPlowman JackPlowman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments about the new examples

@github-actions

github-actions Bot commented May 2, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4831

@JackPlowman JackPlowman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ellie-bound1-NHSD ellie-bound1-NHSD merged commit fe18e96 into master May 2, 2025
13 checks passed
@ellie-bound1-NHSD ellie-bound1-NHSD deleted the dev/NPA-4831/Update-Sandbox-with-Examples-for-Includes-Patient-Detials-Multiple-Relationships branch May 2, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants