Skip to content

NPA-4284: Allow api headers to be case insensitive#205

Merged
ellie-bound1-NHSD merged 6 commits into
masterfrom
dev/NPA-4284/Allow-API-Headers-to-be-Case-Insensitive
May 28, 2025
Merged

NPA-4284: Allow api headers to be case insensitive#205
ellie-bound1-NHSD merged 6 commits into
masterfrom
dev/NPA-4284/Allow-API-Headers-to-be-Case-Insensitive

Conversation

@ellie-bound1-NHSD

@ellie-bound1-NHSD ellie-bound1-NHSD commented May 27, 2025

Copy link
Copy Markdown
Contributor

Pull Request

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-4284

Description/Change Summary

  • Added 2 python script policies
  • 1 Translate Request Headers which translates Request ID and Correlation ID request headers into parcel case to be sent to client. Also store original casing of request headers.
  • 2 Mirror Request Headers in the response which takes the stored original casing of request headers and adds this to the response for both successful and unsuccessful responses.

How to test?

  • Deployed to internal-dev in apigee via making the changes manually, saving revision no. 174 and deploying this to internal-dev
  • Ran regression tests of dev here
  • Have branch with updated api tests that are passing here

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run theRun Postman collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@ellie-bound1-NHSD ellie-bound1-NHSD self-assigned this May 27, 2025
@ellie-bound1-NHSD ellie-bound1-NHSD added the enhancement New feature or request label May 27, 2025
@ellie-bound1-NHSD ellie-bound1-NHSD marked this pull request as draft May 27, 2025 07:47
@ellie-bound1-NHSD ellie-bound1-NHSD force-pushed the dev/NPA-4284/Allow-API-Headers-to-be-Case-Insensitive branch 4 times, most recently from 3055ce7 to 203363a Compare May 27, 2025 10:36
@ellie-bound1-NHSD ellie-bound1-NHSD force-pushed the dev/NPA-4284/Allow-API-Headers-to-be-Case-Insensitive branch from 203363a to e9ea4d1 Compare May 27, 2025 11:02
@NHSDigital NHSDigital deleted a comment from github-actions Bot May 27, 2025
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4284

@NHSDigital NHSDigital deleted a comment from github-actions Bot May 27, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot May 27, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot May 27, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot May 27, 2025
@NHSDigital NHSDigital deleted a comment from github-actions Bot May 27, 2025
@ellie-bound1-NHSD ellie-bound1-NHSD force-pushed the dev/NPA-4284/Allow-API-Headers-to-be-Case-Insensitive branch from 29e73f8 to bae23e2 Compare May 27, 2025 13:11
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4284

@ellie-bound1-NHSD ellie-bound1-NHSD force-pushed the dev/NPA-4284/Allow-API-Headers-to-be-Case-Insensitive branch from bae23e2 to b969d2e Compare May 27, 2025 13:26
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4284

1 similar comment
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4284

@ellie-bound1-NHSD ellie-bound1-NHSD force-pushed the dev/NPA-4284/Allow-API-Headers-to-be-Case-Insensitive branch from 93a84df to 7b1d293 Compare May 27, 2025 14:12
@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4284

@ellie-bound1-NHSD ellie-bound1-NHSD marked this pull request as ready for review May 27, 2025 15:07
@ellie-bound1-NHSD ellie-bound1-NHSD merged commit 7667530 into master May 28, 2025
16 checks passed
@ellie-bound1-NHSD ellie-bound1-NHSD deleted the dev/NPA-4284/Allow-API-Headers-to-be-Case-Insensitive branch May 28, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants