Skip to content

NPA-4531: Update GET/Consent examples & Postman collection#217

Merged
lelliott-hippo merged 13 commits into
masterfrom
dev/NPA-4531-update-consent-examples
Jun 12, 2025
Merged

NPA-4531: Update GET/Consent examples & Postman collection#217
lelliott-hippo merged 13 commits into
masterfrom
dev/NPA-4531-update-consent-examples

Conversation

@kamran-iqbal4-NHSD

@kamran-iqbal4-NHSD kamran-iqbal4-NHSD commented Jun 4, 2025 •
edited by lelliott-hippo
Loading

Copy link
Copy Markdown
Contributor

Pull Request

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-4531

Description/Change Summary

GET/Consent examples:

ADDED:

  • provision - capture the start/end dates and the actor role code (legal basis)
  • extension - modelling statusReason

REMOVED:

  • verification

Postman collection updated:

  • Get proxy roles (Consent)
  • Get proxy role (Consent)

How to test?

  • make test in sandbox environment passed
  • Postman tests passed

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@github-actions

github-actions Bot commented Jun 4, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4531

@lelliott-hippo lelliott-hippo force-pushed the dev/NPA-4531-update-consent-examples branch from 50b6e35 to c8dc682 Compare June 10, 2025 15:07
@github-actions

github-actions Bot commented Jun 10, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4531

1 similar comment
@github-actions

github-actions Bot commented Jun 10, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4531

@lelliott-hippo lelliott-hippo changed the title Dev/npa 4531 update consent examples NPA-4531: Update GET/Consent examples & Postman collection Jun 10, 2025
@lelliott-hippo lelliott-hippo self-assigned this Jun 10, 2025
@lelliott-hippo lelliott-hippo added documentation Improvements or additions to documentation enhancement New feature or request postman Changes to the postman collection labels Jun 10, 2025
@lelliott-hippo lelliott-hippo marked this pull request as ready for review June 10, 2025 15:29
ellie-bound1-NHSD
ellie-bound1-NHSD reviewed Jun 11, 2025
View reviewed changes
Comment thread specification/examples/responses/GET_Consent/filtered-relationships-status-proposed-active.yaml
Comment thread specification/examples/responses/GET_Consent/filtered-relationships-status-proposed-active.yaml
Comment thread specification/examples/responses/GET_Consent/multiple-relationships.yaml
Comment thread specification/examples/responses/GET_Consent/multiple-relationships-include-patient.yaml
Comment thread specification/examples/responses/GET_Consent/multiple-relationships-include-performer.yaml
Comment thread ...ication/examples/responses/GET_Consent/multiple-relationships-include-performer-patient.yaml
Comment thread specification/examples/responses/GET_Consent/multiple-relationships-single-patient.yaml
@ellie-bound1-NHSD

ellie-bound1-NHSD commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

When I fork the postman collection the tests are failing. I believe you need to do a PR just updating the examples which will update sandbox environment and then a separate one for postman.

@github-actions

github-actions Bot commented Jun 11, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4531

3 similar comments
@github-actions

github-actions Bot commented Jun 11, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4531

@github-actions

github-actions Bot commented Jun 11, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4531

@github-actions

github-actions Bot commented Jun 11, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4531

ellie-bound1-NHSD
ellie-bound1-NHSD reviewed Jun 12, 2025
View reviewed changes
Comment thread postman/Validate Relationship Service Sandbox.postman_collection.json
Comment thread ...s/responses/GET_Consent/multiple-relationships-single-patient-include-performer-patient.yaml
Comment thread .../examples/responses/GET_Consent/multiple-relationships-single-patient-include-performer.yaml Outdated
Comment thread specification/examples/responses/GET_Consent/multiple-relationships-single-patient.yaml
Comment thread specification/examples/responses/GET_Consent/multiple-relationships.yaml
Comment thread postman/Validate Relationship Service Sandbox.postman_collection.json Outdated
@github-actions

github-actions Bot commented Jun 12, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4531

ellie-bound1-NHSD
ellie-bound1-NHSD approved these changes Jun 12, 2025
View reviewed changes

@ellie-bound1-NHSD ellie-bound1-NHSD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lelliott-hippo lelliott-hippo force-pushed the dev/NPA-4531-update-consent-examples branch from cfe0525 to 6947f39 Compare June 12, 2025 13:58
@github-actions

github-actions Bot commented Jun 12, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4531

@lelliott-hippo lelliott-hippo force-pushed the dev/NPA-4531-update-consent-examples branch from 6947f39 to c744b37 Compare June 12, 2025 14:10
@github-actions

github-actions Bot commented Jun 12, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4531

@lelliott-hippo lelliott-hippo merged commit 1b1190a into master Jun 12, 2025
17 checks passed
@lelliott-hippo lelliott-hippo deleted the dev/NPA-4531-update-consent-examples branch June 12, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellie-bound1-NHSD ellie-bound1-NHSD ellie-bound1-NHSD approved these changes

Assignees

@lelliott-hippo lelliott-hippo

Labels

documentation Improvements or additions to documentation enhancement New feature or request postman Changes to the postman collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kamran-iqbal4-NHSD @ellie-bound1-NHSD @lelliott-hippo