Skip to content

NPA-5087: GET Consent by ID - sandbox environment and Postman collection updates#218

Merged
ClarksonAdam merged 9 commits into
masterfrom
feat/npa-5087-get-consent-by-id-sandbox-and-postman
Jun 9, 2025
Merged

NPA-5087: GET Consent by ID - sandbox environment and Postman collection updates#218
ClarksonAdam merged 9 commits into
masterfrom
feat/npa-5087-get-consent-by-id-sandbox-and-postman

Conversation

@ClarksonAdam

Copy link
Copy Markdown
Contributor

Pull Request

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5087

Description/Change Summary

  • Added the GET Consent by ID endpoint to sandbox environment
  • Added a new Postman collection folder with example requests for the endpoint
  • Added sandbox tests for the GET Consent endpoint
  • Tidied up documentation on Postman collection to better match the OAS
  • Updated the OAS with new examples for GET Consent/{ID} and fix error typo
  • Updated Postman collection link on OAS to point to new version

How to test?

  • Run Postman collection tests
  • Run sandbox tests
  • Review OAS

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@ClarksonAdam ClarksonAdam self-assigned this Jun 6, 2025
@ClarksonAdam ClarksonAdam added documentation Improvements or additions to documentation enhancement New feature or request python Pull requests that update Python code postman Changes to the postman collection labels Jun 6, 2025
@github-actions

github-actions Bot commented Jun 6, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5087

@github-actions

github-actions Bot commented Jun 6, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5087

@github-actions

github-actions Bot commented Jun 6, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5087

@github-actions

github-actions Bot commented Jun 6, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5087

@JackPlowman JackPlowman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ClarksonAdam ClarksonAdam merged commit bfbc604 into master Jun 9, 2025
17 checks passed
@ClarksonAdam ClarksonAdam deleted the feat/npa-5087-get-consent-by-id-sandbox-and-postman branch June 9, 2025 08:53
lelliott-hippo pushed a commit that referenced this pull request Jun 10, 2025
…ion updates (#218)

* npa-5087 - Added get consent by ID to sandbox

* npa-5087 - Added invalid and missing ID routes

* npa-5087 - Added sandbox tests for get consent by id

* npa-5087 - Updated sandbox

* npa-5087 - Update postman collection

* npa-5087 - Updated OAS and postman collection

* npa-5087 - formatting updates

* npa-5087 - further formatting updates

* npa-5087 - Updated import positioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request postman Changes to the postman collection python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants