Skip to content

NPA-5090 Update GET /Consent/{id} Errors#220

Merged
JackPlowman merged 4 commits into
masterfrom
dev/NPA-5090_GET_Consent_Id_Validation_2
Jun 10, 2025
Merged

NPA-5090 Update GET /Consent/{id} Errors#220
JackPlowman merged 4 commits into
masterfrom
dev/NPA-5090_GET_Consent_Id_Validation_2

Conversation

@JackPlowman

@JackPlowman JackPlowman commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Pull Request

Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5090

Description/Change Summary

  • Removed MISSING_ID_VALUE as error cannot be triggered in AWS
  • Updated invalid include from INVALID_VALUE to INVALID_PARAMETER inline with VRS repo
  • Updated Postman/Sandbox for changes above

How to test?

  • Postman Collection will be tested after merge

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@JackPlowman JackPlowman self-assigned this Jun 9, 2025
@JackPlowman JackPlowman added bug Something isn't working documentation Improvements or additions to documentation python Pull requests that update Python code postman Changes to the postman collection labels Jun 9, 2025
@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5090

@github-actions

github-actions Bot commented Jun 9, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5090

@LeoKHoward LeoKHoward left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still references to INVALID_VALUE in postman/Validate Relationship Service Sandbox.postman_collection.json and specification/validated-relationships-service-api.yaml

Just checking those haven't been missed accidentally

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5090

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5090

@JackPlowman JackPlowman requested a review from LeoKHoward June 10, 2025 08:21

@LeoKHoward LeoKHoward left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@JackPlowman JackPlowman merged commit 96e4e3b into master Jun 10, 2025
17 checks passed
@JackPlowman JackPlowman deleted the dev/NPA-5090_GET_Consent_Id_Validation_2 branch June 10, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation postman Changes to the postman collection python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants