NPA-5140: GET /Consent Invalid Status Wrong Error Code#225
Closed
LeoKHoward wants to merge 3 commits into
Closed
Conversation
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-5140 |
LeoKHoward
added
bug
| " }", | ||
| " ],", | ||
| " \"diagnostics\": \"Invalid request with error - _include parameter is invalid.\"", | ||
| " \"diagnostics\": \"Invalid request with error - status parameter is invalid.\"", |
Contributor
There was a problem hiding this comment.
Neither before or new change seems to be correct looking at the request
"raw": "{{api_base_url}}/Consent/74eed847-ca25-4e76-8cf2-f2c2d7842a7a?_unknown=true
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-5140 |
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-5140 |
LeoKHoward
deleted the
task/NPA-5140/update-get-consent-invalid-status-code
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Ticket Link
https://nhsd-jira.digital.nhs.uk/browse/NPA-5140
Description/Change Summary
Updated INVALID_VALUE code and diagnostics message to match INVALID_PARAMETER one
How to test?
Tested after merge
Review Checklist
ℹ️ This section is to be filled in by the reviewer.
Post-merge
After merging and deploying changes to the sandbox, Postman collection or spec examples please run the
Run Postman collectionworkflow.This will run the tests within the collection to check that the sandbox is working as expected once deployed.