Skip to content

NPA-4986: Fix Specification Incorrect Error Code#230

Merged
JackPlowman merged 2 commits into
masterfrom
docs/NPA-4986_update_spec
Jul 1, 2025
Merged

NPA-4986: Fix Specification Incorrect Error Code#230
JackPlowman merged 2 commits into
masterfrom
docs/NPA-4986_update_spec

Conversation

@JackPlowman

@JackPlowman JackPlowman commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-4986


📄 Description/Summary of Changes

  • Fixed a bug where the incorrect error code was in the spec for a 502 error
  • General improvements to spec to improve DX
  • Ran prettier on .github as part of a slow migration to prettify this repository

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX-<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • The traceability matrix is updated
    with
    new tests or requirements
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4986

@JackPlowman JackPlowman force-pushed the docs/NPA-4986_update_spec branch from 5d89a29 to 4be51f6 Compare July 1, 2025 08:21
@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-4986

@JackPlowman JackPlowman changed the title NPA-4986 Run Prettier on .github folder NPA-4986 Fix Specification Incorrect Error Code Jul 1, 2025
@JackPlowman JackPlowman self-assigned this Jul 1, 2025
@JackPlowman JackPlowman added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request endpoints labels Jul 1, 2025
@JackPlowman JackPlowman marked this pull request as ready for review July 1, 2025 08:25
@JackPlowman JackPlowman changed the title NPA-4986 Fix Specification Incorrect Error Code NPA-4986: Fix Specification Incorrect Error Code Jul 1, 2025
@JackPlowman JackPlowman merged commit 3976727 into master Jul 1, 2025
17 checks passed
@JackPlowman JackPlowman deleted the docs/NPA-4986_update_spec branch July 1, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation endpoints enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants