Skip to content

NPA-5214: Fix Extension valueCodeableConcept Schema#233

Merged
LeoKHoward merged 3 commits into
masterfrom
bug/NPA-5214/fix-extension-valueCodeableConcept-schema
Jul 10, 2025
Merged

NPA-5214: Fix Extension valueCodeableConcept Schema#233
LeoKHoward merged 3 commits into
masterfrom
bug/NPA-5214/fix-extension-valueCodeableConcept-schema

Conversation

@LeoKHoward

@LeoKHoward LeoKHoward commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-5214


📄 Description/Summary of Changes

  • Corrects the valueCodeableConcept field in the Extension schema and response examples for GET /Consent and GET /Consent/{id} endpoints

  • Updated the Extension schema in the OAS to define valueCodeableConcept as a single CodeableConcept object instead of an array

  • Modified all example response files for GET /Consent and GET /Consent/{id} under components/schemas/ConsentBundle to correct the valueCodeableConcept structure in the extension field of Consent resources to ensure it is a single object with a coding array and an optional text field

  • Used text of "To be confirmed" in examples pending team guidance on replacing with proper input

  • Updated Postman Try It Out URL


🧪 Developer Testing Carried Out

  • Manual review of changes
  • Validated OAS via Swagger

🧪 Reviewer Testing Required

  • Manual review of changes

✅ Developer Checklist

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX-<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>
  • All acceptance criteria from the Jira ticket are addressed
  • Automated tests (unit/integration/API/infrastructure etc. tests) are added or updated
  • The traceability matrix is updated
    with
    new tests or requirements
  • Assignees and appropriate labels (e.g. terraform, documentation) are added

👀 Reviewer Checklist

  • Changes meet the acceptance criteria of the Jira ticket
  • Code is able to be merged (no conflicts and adheres to coding standards)
  • Sufficient test evidence is provided (manual and/or automated)
  • Infrastructure/operational/build changes are validated (if applicable)

🚀 Post-merge

After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.

This will run the tests within the collection to check that the sandbox is working as expected once deployed.

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5214

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5214

@github-actions

Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-5214

@LeoKHoward LeoKHoward self-assigned this Jul 10, 2025
@LeoKHoward LeoKHoward added bug Something isn't working postman Changes to the postman collection endpoints labels Jul 10, 2025
@JackPlowman JackPlowman changed the title NPA-5214: Fix Extenstion valueCodeableConcept Schema NPA-5214: Fix Extension valueCodeableConcept Schema Jul 10, 2025

@JackPlowman JackPlowman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, please ensure the postman collection changes work once the PR has merged in and the sandbox has deployed

@LeoKHoward LeoKHoward merged commit 2d02c20 into master Jul 10, 2025
17 checks passed
@LeoKHoward LeoKHoward deleted the bug/NPA-5214/fix-extension-valueCodeableConcept-schema branch July 10, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working endpoints postman Changes to the postman collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants