NPA-5214: Fix Extension valueCodeableConcept Schema#233
Merged
LeoKHoward merged 3 commits intoJul 10, 2025
Conversation
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-5214 |
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-5214 |
|
This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket: NPA-5214 |
JackPlowman
approved these changes
Jul 10, 2025
JackPlowman
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍, please ensure the postman collection changes work once the PR has merged in and the sandbox has deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🧾 Ticket Link
https://nhsd-jira.digital.nhs.uk/browse/NPA-5214
📄 Description/Summary of Changes
Corrects the valueCodeableConcept field in the Extension schema and response examples for GET /Consent and GET /Consent/{id} endpoints
Updated the Extension schema in the OAS to define valueCodeableConcept as a single CodeableConcept object instead of an array
Modified all example response files for GET /Consent and GET /Consent/{id} under components/schemas/ConsentBundle to correct the valueCodeableConcept structure in the extension field of Consent resources to ensure it is a single object with a coding array and an optional text field
Used text of "To be confirmed" in examples pending team guidance on replacing with proper input
Updated Postman Try It Out URL
🧪 Developer Testing Carried Out
🧪 Reviewer Testing Required
✅ Developer Checklist
NPA-XXXX: <short-description><type>/NPA-XXXX-<short-description>NPA-XXXX: <short-description>with
new tests or requirements
terraform,documentation) are added👀 Reviewer Checklist
🚀 Post-merge
After merging and deploying changes to the sandbox, Postman collection or spec examples please run the Run Postman
collection workflow.
This will run the tests within the collection to check that the sandbox is working as expected once deployed.